Bug 221756

Summary:

JSC EWSes should be triggered by change in any jsc file

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, don.olmstead, jbedard, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Aakash Jain 2021-02-11 08:51:56 PST

JSC EWSes should be triggered by change in any jsc file. It wasn't triggered on https://bugs.webkit.org/show_bug.cgi?id=221726 which changed Source/cmake/OptionsJSCOnly.cmake

Comment 1 Aakash Jain 2021-02-11 08:56:53 PST

Created attachment 419995 [details]
Patch

Comment 2 Jonathan Bedard 2021-02-11 09:03:57 PST

Comment on attachment 419995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419995&action=review

> Tools/CISupport/ews-build/steps.py:-338
> -        'Source/JavaScriptCore/',

Are the regexes not case-sensitive?

Comment 3 Aakash Jain 2021-02-11 09:21:32 PST

(In reply to Jonathan Bedard from comment #2)
> Are the regexes not case-sensitive?
Nope, we use re.IGNORECASE in re.search()

Comment 4 EWS 2021-02-11 10:50:45 PST

Committed r272738: <https://commits.webkit.org/r272738>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419995 [details].

Comment 5 Radar WebKit Bug Importer 2021-02-11 10:51:13 PST

<rdar://problem/74241656>