Bug 221476

Summary: [ews] commit-queue should use commits.webkit.org url instead of trac url
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2021-02-05 09:23:03 PST
commit-queue should use commits.webkit.org url instead of trac url. commits.webkit.org is a redirection service, which currently redirects to trac, but will start redirecting to github in future. When we switch commits.webkit.org to redirect to github, all old commits.webkit.org urls would redirect to github appropriately.
Attachments
Patch (2.18 KB, patch)
2021-02-05 09:24 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2021-02-05 09:24:57 PST
Created attachment 419417 [details] Patch
Jonathan Bedard
Comment 2 2021-02-05 10:10:12 PST
Comment on attachment 419417 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419417&action=review > Tools/CISupport/ews-build/steps.py:3109 > + return 'https://commits.webkit.org/r{}'.format(revision) I think we should use identifiers here, but this is good step in the right direction, so I'm going to r+ it.
EWS
Comment 3 2021-02-05 10:31:51 PST
Committed r272423: <https://trac.webkit.org/changeset/272423> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419417 [details].
Radar WebKit Bug Importer
Comment 4 2021-02-05 10:32:30 PST
<rdar://problem/74030830>
Aakash Jain
Comment 5 2021-02-06 06:08:44 PST
Restarted buildbot to pick up this change.
Aakash Jain
Comment 6 2021-02-06 16:08:54 PST
Working fine, e.g.: https://bugs.webkit.org/show_bug.cgi?id=221502#c4
Note You need to log in before you can comment on or make changes to this bug.