Bug 221454

Summary: [JSC] globalFuncCopyDataProperties should not perform GC-sensitive operation in the middle of Structure::forEachProperty
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=221557
Attachments:
Description Flags
Patch
none
Patch
none
Patch mark.lam: review+

Yusuke Suzuki
Reported 2021-02-05 01:17:24 PST
[JSC] globalFuncCopyDataProperties should not perform GC-sesitive operation in the middle of Structure::forEachProperty
Attachments
Patch (3.47 KB, patch)
2021-02-05 01:18 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (4.30 KB, patch)
2021-02-05 01:30 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (4.37 KB, patch)
2021-02-05 01:31 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-02-05 01:18:45 PST
Created attachment 419370 [details] Patch
Yusuke Suzuki
Comment 2 2021-02-05 01:30:12 PST
Created attachment 419371 [details] Patch
Yusuke Suzuki
Comment 3 2021-02-05 01:31:13 PST
Created attachment 419372 [details] Patch
Yusuke Suzuki
Comment 4 2021-02-05 01:32:14 PST
<rdar://problem/73974480>
Mark Lam
Comment 5 2021-02-05 10:32:09 PST
Comment on attachment 419372 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419372&action=review r=me > Source/JavaScriptCore/ChangeLog:3 > + [JSC] globalFuncCopyDataProperties should not perform GC-sesitive operation in the middle of Structure::forEachProperty /sesitive/sensitive/
Yusuke Suzuki
Comment 6 2021-02-05 10:55:23 PST
Comment on attachment 419372 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419372&action=review >> Source/JavaScriptCore/ChangeLog:3 >> + [JSC] globalFuncCopyDataProperties should not perform GC-sesitive operation in the middle of Structure::forEachProperty > > /sesitive/sensitive/ Fixed!
Yusuke Suzuki
Comment 7 2021-02-05 10:58:12 PST
Committed r272428: <https://trac.webkit.org/changeset/272428>
Yusuke Suzuki
Comment 8 2021-02-05 11:08:45 PST
Committed r272430: <https://trac.webkit.org/changeset/272430>
Note You need to log in before you can comment on or make changes to this bug.