Bug 221454

Summary: [JSC] globalFuncCopyDataProperties should not perform GC-sensitive operation in the middle of Structure::forEachProperty
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=221557
Attachments:
Description Flags
Patch
none
Patch
none
Patch mark.lam: review+

Description Yusuke Suzuki 2021-02-05 01:17:24 PST 
[JSC] globalFuncCopyDataProperties should not perform GC-sesitive operation in the middle of Structure::forEachProperty
Comment 1 Yusuke Suzuki 2021-02-05 01:18:45 PST 
Created attachment 419370 [details]
Patch
Comment 2 Yusuke Suzuki 2021-02-05 01:30:12 PST 
Created attachment 419371 [details]
Patch
Comment 3 Yusuke Suzuki 2021-02-05 01:31:13 PST 
Created attachment 419372 [details]
Patch
Comment 4 Yusuke Suzuki 2021-02-05 01:32:14 PST 
<rdar://problem/73974480>
Comment 5 Mark Lam 2021-02-05 10:32:09 PST 
Comment on attachment 419372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419372&action=review

r=me

> Source/JavaScriptCore/ChangeLog:3
> +        [JSC] globalFuncCopyDataProperties should not perform GC-sesitive operation in the middle of Structure::forEachProperty

/sesitive/sensitive/
Comment 6 Yusuke Suzuki 2021-02-05 10:55:23 PST 
Comment on attachment 419372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419372&action=review

>> Source/JavaScriptCore/ChangeLog:3
>> +        [JSC] globalFuncCopyDataProperties should not perform GC-sesitive operation in the middle of Structure::forEachProperty
> 
> /sesitive/sensitive/

Fixed!
Comment 7 Yusuke Suzuki 2021-02-05 10:58:12 PST 
Committed r272428: <https://trac.webkit.org/changeset/272428>
Comment 8 Yusuke Suzuki 2021-02-05 11:08:45 PST 
Committed r272430: <https://trac.webkit.org/changeset/272430>