Summary: | Make shouldComputeLogicalWidthFromAspectRatioAndInsets writing mode aware | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||
Component: | CSS | Assignee: | Rob Buis <rbuis> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, rego, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 47738 | ||||||
Attachments: |
|
Description
Rob Buis
2021-02-03 06:09:22 PST
Created attachment 419128 [details]
Patch
Comment on attachment 419128 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419128&action=review r=me, with a nit comment inline. > Source/WebCore/rendering/RenderBox.cpp:5100 > + if (style().width().isAuto() && style().height().isAuto() && !style().logicalTop().isAuto() && !style().logicalBottom().isAuto() && (style().logicalLeft().isAuto() || style().logicalRight().isAuto())) What about logicalWidth() instead of width()? I guess it doesn't really matter as we have an and for width and height, but maybe it'd be worth changing for consistency dunno. Comment on attachment 419128 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419128&action=review >> Source/WebCore/rendering/RenderBox.cpp:5100 >> + if (style().width().isAuto() && style().height().isAuto() && !style().logicalTop().isAuto() && !style().logicalBottom().isAuto() && (style().logicalLeft().isAuto() || style().logicalRight().isAuto())) > > What about logicalWidth() instead of width()? I guess it doesn't really matter as we have an and for width and height, but maybe it'd be worth changing for consistency dunno. Interesting idea, but ultimately we need to check both dimensions and using the logical variants is a bit slower. So I'll keep as-is. Committed r272363: <https://trac.webkit.org/changeset/272363> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419128 [details]. |