Bug 221208

Summary: [build.webkit.org] is_test_mode_enabled should default to True
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=196248
Bug Depends on:    
Bug Blocks: 175056    
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2021-02-01 07:40:53 PST
Similar to https://bugs.webkit.org/show_bug.cgi?id=196248, is_test_mode_enabled variable should default to True in order to avoid accidentally running production settings on a local/test instance. Currently we need to explicitly add an environment variable BUILDBOT_TESTING in order to indicate test instance. If someone forgets to set this environment variable on a local instance, he/she would run with production settings. Currently it's very easy to make this mistake. We should reverse the logic to make it harder to do such mistake. We should instead require to set an environment variable BUILDBOT_PRODUCTION on production server. It will be a one time configuration on the production server (by configuring environment variable in a manner that persist across reboots and various shell sessions).
Attachments
Patch (1.06 KB, patch)
2021-02-01 07:41 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2021-02-01 07:41:43 PST
Created attachment 418872 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-02-01 08:05:34 PST
<rdar://problem/73829462>
EWS
Comment 3 2021-02-01 09:07:51 PST
Committed r272144: <https://trac.webkit.org/changeset/272144> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418872 [details].
Note You need to log in before you can comment on or make changes to this bug.