RESOLVED FIXED 196248
[ews-build] is_test_mode_enabled should default to True 
https://bugs.webkit.org/show_bug.cgi?id=196248
Summary [ews-build] is_test_mode_enabled should default to True
Aakash Jain
Reported 2019-03-26 04:48:48 PDT
is_test_mode_enabled variable should default to True in order to avoid accidentally running production settings on a local/test instance. Currently we need to explicitly add an environment variable BUILDBOT_TESTING in order to indicate test instance. If someone forgets to set this environment variable on a local instance, he would run with production settings. Currently it's very easy to make this mistake. We should reverse the logic to make it harder to do such mistake. We should instead require to set an environment variable BUILDBOT_PRODUCTION on production server. It will be a one time configuration on the production server (by configuring environment variable in a manner that persist across reboots and various shell sessions).
Attachments
Patch (1.11 KB, patch)
2019-03-26 04:50 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-03-26 04:50:32 PDT
Created attachment 365960 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-03-26 04:55:00 PDT
<rdar://problem/49263519>
WebKit Commit Bot
Comment 3 2019-03-26 10:12:28 PDT
Comment on attachment 365960 [details] Patch Clearing flags on attachment: 365960 Committed r243501: <https://trac.webkit.org/changeset/243501>
WebKit Commit Bot
Comment 4 2019-03-26 10:12:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.