is_test_mode_enabled variable should default to True in order to avoid accidentally running production settings on a local/test instance. Currently we need to explicitly add an environment variable BUILDBOT_TESTING in order to indicate test instance. If someone forgets to set this environment variable on a local instance, he would run with production settings. Currently it's very easy to make this mistake. We should reverse the logic to make it harder to do such mistake.
We should instead require to set an environment variable BUILDBOT_PRODUCTION on production server. It will be a one time configuration on the production server (by configuring environment variable in a manner that persist across reboots and various shell sessions).
Created attachment 365960 [details]
Comment on attachment 365960 [details]
Clearing flags on attachment: 365960
Committed r243501: <https://trac.webkit.org/changeset/243501>
All reviewed patches have been landed. Closing bug.