Bug 221058

Summary: [iOS] add accessibility image extraction contextmenu item for revealing images
Product: WebKit Reporter: Devin Rousso <hi>
Component: PlatformAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=219524
https://bugs.webkit.org/show_bug.cgi?id=219398
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Devin Rousso
Reported 2021-01-27 14:09:11 PST
.
Attachments
Patch (10.37 KB, patch)
2021-01-27 14:33 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (9.40 KB, patch)
2021-01-27 15:23 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (14.58 KB, patch)
2021-01-27 15:51 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-01-27 14:14:41 PST
<rdar://problem/73382220>
Devin Rousso
Comment 2 2021-01-27 14:33:14 PST
Created attachment 418583 [details] Patch
Wenson Hsieh
Comment 3 2021-01-27 14:41:18 PST
Comment on attachment 418583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418583&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKElementActionInternal.h:41 > +#if ENABLE(IMAGE_EXTRACTION) > ++ (UIImage *)imageForElementActionTypeImageExtraction; > ++ (UIImage *)imageForElementActionTypeRevealImage; > +#endif Since these methods are only used inside _WKElementAction.mm, you don't need to declare them in this internal header as well.
Devin Rousso
Comment 4 2021-01-27 15:23:06 PST
Created attachment 418589 [details] Patch
Devin Rousso
Comment 5 2021-01-27 15:51:33 PST
Created attachment 418593 [details] Patch
EWS
Comment 6 2021-01-27 17:11:50 PST
Committed r271991: <https://trac.webkit.org/changeset/271991> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418593 [details].
Note You need to log in before you can comment on or make changes to this bug.