Bug 221058

Summary: [iOS] add accessibility image extraction contextmenu item for revealing images
Product: WebKit Reporter: Devin Rousso <hi>
Component: PlatformAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=219524
https://bugs.webkit.org/show_bug.cgi?id=219398
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Devin Rousso 2021-01-27 14:09:11 PST
.
Comment 1 Devin Rousso 2021-01-27 14:14:41 PST
<rdar://problem/73382220>
Comment 2 Devin Rousso 2021-01-27 14:33:14 PST
Created attachment 418583 [details]
Patch
Comment 3 Wenson Hsieh 2021-01-27 14:41:18 PST
Comment on attachment 418583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418583&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKElementActionInternal.h:41
> +#if ENABLE(IMAGE_EXTRACTION)
> ++ (UIImage *)imageForElementActionTypeImageExtraction;
> ++ (UIImage *)imageForElementActionTypeRevealImage;
> +#endif

Since these methods are only used inside _WKElementAction.mm, you don't need to declare them in this internal header as well.
Comment 4 Devin Rousso 2021-01-27 15:23:06 PST
Created attachment 418589 [details]
Patch
Comment 5 Devin Rousso 2021-01-27 15:51:33 PST
Created attachment 418593 [details]
Patch
Comment 6 EWS 2021-01-27 17:11:50 PST
Committed r271991: <https://trac.webkit.org/changeset/271991>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418593 [details].