Bug 220967

Summary: Use WebRTC GPU process flag for MediaRecorder
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=221161
Bug Depends on: 221132, 221195, 221197    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Rebasing none

Description youenn fablet 2021-01-26 01:43:48 PST
Use WebRTC GPU process flag for MediaRecorder
Comment 1 youenn fablet 2021-01-26 01:48:40 PST
Created attachment 418381 [details]
Patch
Comment 2 youenn fablet 2021-01-26 04:15:57 PST
Created attachment 418393 [details]
Patch
Comment 3 youenn fablet 2021-01-26 07:55:48 PST
Created attachment 418420 [details]
Patch
Comment 4 EWS 2021-01-29 00:53:19 PST
Committed r272052: <https://trac.webkit.org/changeset/272052>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418420 [details].
Comment 5 Radar WebKit Bug Importer 2021-01-29 00:55:14 PST
<rdar://problem/73745023>
Comment 6 Aakash Jain 2021-01-29 07:06:04 PST
(In reply to EWS from comment #4)
> Committed r272052: <https://trac.webkit.org/changeset/272052>
This seems to be causing following wk2 test to fail (note that EWS didn't caught it probably because ews bots were on Mojave, and this failure is on Catalina. EWS bots are being updated to Catalina) 

https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fmediacapture-record%2FMediaRecorder-stop.html
Comment 7 WebKit Commit Bot 2021-01-29 07:09:19 PST
Re-opened since this is blocked by bug 221132
Comment 8 youenn fablet 2021-02-02 02:44:57 PST
http/wpt/mediarecorder/mute-tracks.html is already flaky without this patch and will be fixed in https://bugs.webkit.org/show_bug.cgi?id=221195.
Relanding.
Comment 9 EWS 2021-02-02 02:45:43 PST
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Comment 10 youenn fablet 2021-02-02 02:52:08 PST
Created attachment 418978 [details]
Rebasing
Comment 11 EWS 2021-02-02 04:12:08 PST
commit-queue failed to commit attachment 418978 [details] to WebKit repository.
Comment 12 EWS 2021-02-02 04:31:10 PST
Committed r272206: <https://trac.webkit.org/changeset/272206>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418978 [details].