Bug 220967

Summary: Use WebRTC GPU process flag for MediaRecorder
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=221161
Bug Depends on: 221132, 221195, 221197    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Rebasing none

youenn fablet
Reported 2021-01-26 01:43:48 PST
Use WebRTC GPU process flag for MediaRecorder
Attachments
Patch (11.14 KB, patch)
2021-01-26 01:48 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (17.21 KB, patch)
2021-01-26 04:15 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (15.83 KB, patch)
2021-01-26 07:55 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Rebasing (15.86 KB, patch)
2021-02-02 02:52 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-01-26 01:48:40 PST
Created attachment 418381 [details] Patch
youenn fablet
Comment 2 2021-01-26 04:15:57 PST
Created attachment 418393 [details] Patch
youenn fablet
Comment 3 2021-01-26 07:55:48 PST
Created attachment 418420 [details] Patch
EWS
Comment 4 2021-01-29 00:53:19 PST
Committed r272052: <https://trac.webkit.org/changeset/272052> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418420 [details].
Radar WebKit Bug Importer
Comment 5 2021-01-29 00:55:14 PST
<rdar://problem/73745023>
Aakash Jain
Comment 6 2021-01-29 07:06:04 PST
(In reply to EWS from comment #4) > Committed r272052: <https://trac.webkit.org/changeset/272052> This seems to be causing following wk2 test to fail (note that EWS didn't caught it probably because ews bots were on Mojave, and this failure is on Catalina. EWS bots are being updated to Catalina) https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fmediacapture-record%2FMediaRecorder-stop.html
WebKit Commit Bot
Comment 7 2021-01-29 07:09:19 PST
Re-opened since this is blocked by bug 221132
youenn fablet
Comment 8 2021-02-02 02:44:57 PST
http/wpt/mediarecorder/mute-tracks.html is already flaky without this patch and will be fixed in https://bugs.webkit.org/show_bug.cgi?id=221195. Relanding.
EWS
Comment 9 2021-02-02 02:45:43 PST
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
youenn fablet
Comment 10 2021-02-02 02:52:08 PST
Created attachment 418978 [details] Rebasing
EWS
Comment 11 2021-02-02 04:12:08 PST
commit-queue failed to commit attachment 418978 [details] to WebKit repository.
EWS
Comment 12 2021-02-02 04:31:10 PST
Committed r272206: <https://trac.webkit.org/changeset/272206> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418978 [details].
Note You need to log in before you can comment on or make changes to this bug.