Bug 221195 - http/wpt/mediarecorder/mute-tracks.html is flaky
Summary: http/wpt/mediarecorder/mute-tracks.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
: 221161 (view as bug list)
Depends on:
Blocks: 220967
  Show dependency tree / graph
 
Reported: 2021-02-01 01:04 PST by youenn fablet
Modified: 2021-02-02 21:10 PST (History)
9 users (show)

See Also:

Attachments
Patch (4.63 KB, patch)
2021-02-01 01:07 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (4.63 KB, patch)
2021-02-01 01:49 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (4.61 KB, patch)
2021-02-01 01:52 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (4.75 KB, patch)
2021-02-02 08:49 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (4.63 KB, patch)
2021-02-02 11:40 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-02-01 01:04:37 PST 
http/wpt/mediarecorder/mute-tracks.html is flaky
Comment 1 youenn fablet 2021-02-01 01:07:12 PST 
Created attachment 418841 [details]
Patch
Comment 2 youenn fablet 2021-02-01 01:49:08 PST 
Created attachment 418845 [details]
Patch
Comment 3 youenn fablet 2021-02-01 01:52:45 PST 
Created attachment 418846 [details]
Patch
Comment 4 youenn fablet 2021-02-01 05:25:08 PST 
*** Bug 221161 has been marked as a duplicate of this bug. ***
Comment 5 youenn fablet 2021-02-01 05:25:33 PST 
<rdar://problem/73775908>
Comment 6 Eric Carlson 2021-02-02 08:33:51 PST 
Comment on attachment 418846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418846&action=review

> LayoutTests/http/wpt/mediarecorder/mute-tracks.html:91
> -    var context = new AudioContext();
> +    let context = new AudioContext();
> +    let analyser = setupAudioContext(context, streamOrVideo);
>      for (var cptr = 0; cptr < 20; cptr++) {
> -        var results = await analyseAudio(streamOrVideo, 200, context);
> -        if (results.heardHum === expected)
> +        var results = await analyseAudio(analyser, 200, context);

Nit: it is inconsistent to change only some of the `var` declarations to `let`.
Comment 7 youenn fablet 2021-02-02 08:49:38 PST 
Created attachment 419004 [details]
Patch for landing
Comment 8 EWS 2021-02-02 11:09:18 PST 
Found 1 new test failure: http/wpt/mediarecorder/mute-tracks.html
Comment 9 youenn fablet 2021-02-02 11:40:56 PST 
Created attachment 419037 [details]
Patch for landing
Comment 10 EWS 2021-02-02 15:41:42 PST 
commit-queue failed to commit attachment 419037 [details] to WebKit repository.
Comment 11 EWS 2021-02-02 21:10:49 PST 
Committed r272296: <https://trac.webkit.org/changeset/272296>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419037 [details].