Bug 221195 – http/wpt/mediarecorder/mute-tracks.html is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

http/wpt/mediarecorder/mute-tracks.html is flaky

[youenn fablet]

Created attachment 418841 [details]
Patch

[youenn fablet]

Created attachment 418845 [details]
Patch

[youenn fablet]

Created attachment 418846 [details]
Patch

[youenn fablet]

*** Bug 221161 has been marked as a duplicate of this bug. ***

[youenn fablet]

<rdar://problem/73775908>

[Eric Carlson]

Comment on attachment 418846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418846&action=review

> LayoutTests/http/wpt/mediarecorder/mute-tracks.html:91
> -    var context = new AudioContext();
> +    let context = new AudioContext();
> +    let analyser = setupAudioContext(context, streamOrVideo);
>      for (var cptr = 0; cptr < 20; cptr++) {
> -        var results = await analyseAudio(streamOrVideo, 200, context);
> -        if (results.heardHum === expected)
> +        var results = await analyseAudio(analyser, 200, context);

Nit: it is inconsistent to change only some of the `var` declarations to `let`.

[youenn fablet]

Created attachment 419004 [details]
Patch for landing

[EWS]

Found 1 new test failure: http/wpt/mediarecorder/mute-tracks.html

[youenn fablet]

Created attachment 419037 [details]
Patch for landing

[EWS]

commit-queue failed to commit attachment 419037 [details] to WebKit repository.

[EWS]

Committed r272296: <https://trac.webkit.org/changeset/272296>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419037 [details].