Bug 221197 - imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-stop.html is flaky when GPUProcess is enabled
Summary: imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-stop.html i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks: 220967
  Show dependency tree / graph
 
Reported: 2021-02-01 01:43 PST by youenn fablet
Modified: 2021-02-02 02:26 PST (History)
8 users (show)

See Also:

Attachments
Patch (16.23 KB, patch)
2021-02-01 01:47 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-02-01 01:43:11 PST 
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-stop.html is flaky when GPUProcess is enabled
Comment 1 youenn fablet 2021-02-01 01:47:08 PST 
Created attachment 418844 [details]
Patch
Comment 2 Eric Carlson 2021-02-01 09:02:51 PST 
Comment on attachment 418844 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418844&action=review

> Source/WebCore/Modules/mediarecorder/MediaRecorder.h:102
> +        void stopRecordingInternal(CompletionHandler<void()>&& = [] { });

Nit: extra white space.
Comment 3 youenn fablet 2021-02-02 02:11:08 PST 
(In reply to Eric Carlson from comment #2)
> Comment on attachment 418844 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418844&action=review
> 
> > Source/WebCore/Modules/mediarecorder/MediaRecorder.h:102
> > +        void stopRecordingInternal(CompletionHandler<void()>&& = [] { });
> 
> Nit: extra white space.

I do not see it, landing for now, I can fix it post landing if needed.
Comment 4 EWS 2021-02-02 02:25:58 PST 
Committed r272200: <https://trac.webkit.org/changeset/272200>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418844 [details].
Comment 5 Radar WebKit Bug Importer 2021-02-02 02:26:23 PST 
<rdar://problem/73871557>