Bug 220589

Summary: [build.webkit.org] Use PostgreSQL for new build.webkit.org database
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, lingho, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=196229
https://bugs.webkit.org/show_bug.cgi?id=235296
Bug Depends on:    
Bug Blocks: 175056    
Attachments:
Description Flags
Patch none

Description Aakash Jain 2021-01-13 06:15:40 PST 
Use PostgreSQL for upcoming build.webkit.org database since it's much better than the default sqlite. The new build.webkit.org would be running latest Buildbot (which uses database heavily).
Comment 1 Aakash Jain 2021-01-13 06:36:04 PST 
Also, it might be better to use passwords.json to store db info (like db url, username etc.) instead of environment variables.
Comment 2 Aakash Jain 2021-01-13 06:39:55 PST 
Created attachment 417529 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2021-01-13 06:44:15 PST 
<rdar://problem/73149418>
Comment 4 lingho@apple.com 2021-01-13 09:51:41 PST 
rs+
Comment 5 Jonathan Bedard 2021-01-13 10:55:07 PST 
Comment on attachment 417529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417529&action=review

> Tools/CISupport/build-webkit-org/master_buildbot2.cfg:-2
> -# ex: set syntax=python:

Sure we want to remove these lines?
Comment 6 Aakash Jain 2021-01-13 12:04:38 PST 
(In reply to Jonathan Bedard from comment #5)
> Sure we want to remove these lines?
Yeah, I don't see much benefit of keeping them. EWS master.cfg also doesn't have these.
Comment 7 EWS 2021-01-13 12:21:40 PST 
Committed r271450: <https://trac.webkit.org/changeset/271450>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417529 [details].