Bug 196229 - [ews-build] Use PostgreSQL for ews-build database
Summary: [ews-build] Use PostgreSQL for ews-build database
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-25 16:51 PDT by Aakash Jain
Modified: 2021-01-13 06:34 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.90 KB, patch)
2019-03-25 16:52 PDT, Aakash Jain 		lforschler: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-03-25 16:51:26 PDT 
Use PostgreSQL for ews-build database since it's much better than the default sqlite.
Comment 1 Aakash Jain 2019-03-25 16:52:32 PDT 
Created attachment 365920 [details]
Patch
Comment 2 Lucas Forschler 2019-03-26 09:50:17 PDT 
Comment on attachment 365920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365920&action=review

> Tools/BuildSlaveSupport/ews-build/master.cfg:31
> +    password = os.getenv('DB_PASSWORD', None)

I'd stick with your convention above and call these db_username and db_password

> Tools/BuildSlaveSupport/ews-build/master.cfg:32
> +    if db_url is None or db_name is None or password is None or username is None:

I find long comparisons like this clunky...

how about something like:

if None in [db_url, db_name, db_username, db_password]:
Comment 3 Lucas Forschler 2019-03-26 09:56:20 PDT 
Comment on attachment 365920 [details]
Patch

r+ with above changes.
Comment 4 Aakash Jain 2019-03-26 11:20:25 PDT 
Committed r243509: <https://trac.webkit.org/changeset/243509>
Comment 5 Radar WebKit Bug Importer 2019-03-26 11:21:26 PDT 
<rdar://problem/49282338>