Bug 220466

Summary:

A video element needs to ignore the request to enter/exit fullscreen before the current fullscreen mode change is completed

Product:

WebKit

Reporter:

Peng Liu <peng.liu6>

Component:

Media

Assignee:

Peng Liu <peng.liu6>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, pnormand, sergio, tsavell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=220530
https://bugs.webkit.org/show_bug.cgi?id=220540

Attachments:

Description	Flags
Patch	jer.noble: review+, ews-feeder: commit-queue-
Fix a layout test failure	none
A follow-up patch to fix test timeout	none

Description Peng Liu 2021-01-08 09:51:48 PST

A video element needs to ignore the request to enter/exit fullscreen before the current fullscreen mode change is done

Comment 1 Peng Liu 2021-01-08 10:10:16 PST

<rdar://problem/72902078>

Comment 2 Peng Liu 2021-01-08 10:12:16 PST

Created attachment 417276 [details]
Patch

Comment 3 Peng Liu 2021-01-08 14:04:55 PST

Created attachment 417302 [details]
Fix a layout test failure

Comment 4 EWS 2021-01-08 19:11:10 PST

Committed r271341: <https://trac.webkit.org/changeset/271341>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417302 [details].

Comment 5 Philippe Normand 2021-01-11 07:39:03 PST

This test is no longer flaky on GTK/WPE, it's now a timeout... Progress?

Comment 6 Philippe Normand 2021-01-11 07:40:46 PST

Comment on attachment 417302 [details]
Fix a layout test failure

View in context: https://bugs.webkit.org/attachment.cgi?id=417302&action=review

> LayoutTests/media/media-fullscreen.js:44
> +        await testExpectedEventually("internals.isChangingPresentationMode(mediaElement)", false);

GTK/WPE don't enable VIDEO_PRESENTATION_MODE yet, I suppose that's why the test now times out for us.

Comment 7 Truitt Savell 2021-01-11 08:55:59 PST

media/modern-media-controls/media-controller/media-controller-fullscreen-change.html

this test is now timing out after the changes in https://trac.webkit.org/changeset/271341/webkit

History:
https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Fmedia-controller%2Fmedia-controller-fullscreen-change.html

Comment 8 Peng Liu 2021-01-11 09:38:40 PST

(In reply to Philippe Normand from comment #6)
> Comment on attachment 417302 [details]
> Fix a layout test failure
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=417302&action=review
> 
> > LayoutTests/media/media-fullscreen.js:44
> > +        await testExpectedEventually("internals.isChangingPresentationMode(mediaElement)", false);
> 
> GTK/WPE don't enable VIDEO_PRESENTATION_MODE yet, I suppose that's why the
> test now times out for us.

So we had better disable the test for GTK/WPE?

Comment 9 Peng Liu 2021-01-11 10:47:46 PST

Reopening to attach new patch.

Comment 10 Peng Liu 2021-01-11 10:47:48 PST

Created attachment 417392 [details]
A follow-up patch to fix test timeout

Comment 11 EWS 2021-01-11 13:34:01 PST

Committed r271377: <https://trac.webkit.org/changeset/271377>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417392 [details].