Bug 220018

Summary: [Mojave] webanimations/accelerated-transform-related-animation-property-order.html is failing
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, graouts, sam, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=217851
Attachments:
Description Flags
actual
none
expected
none
Patch sam: review+, ews-feeder: commit-queue-

Attachments
actual (10.26 KB, image/png)
2020-12-18 14:04 PST, Ryan Haddad 		no flags
Details
expected (10.24 KB, image/png)
2020-12-18 14:04 PST, Ryan Haddad 		no flags
Details
Patch (1.54 KB, patch)
2021-03-06 12:15 PST, Antoine Quint 		sam: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-12-18 10:20:13 PST
<rdar://problem/72471813>
Ryan Haddad
Comment 2 2020-12-18 10:23:56 PST
Marked test as failing in https://trac.webkit.org/changeset/270973/webkit
Ryan Haddad
Comment 3 2020-12-18 14:04:08 PST
Created attachment 416544 [details] actual
Ryan Haddad
Comment 4 2020-12-18 14:04:18 PST
Created attachment 416545 [details] expected
Ryan Haddad
Comment 5 2020-12-18 15:18:27 PST
It looks like this test was previously marked as failing, then that was removed as part of https://bugs.webkit.org/show_bug.cgi?id=217851
Antoine Quint
Comment 6 2021-03-06 12:15:29 PST
Created attachment 422504 [details] Patch
Sam Weinig
Comment 7 2021-03-07 09:01:25 PST
Comment on attachment 422504 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422504&action=review > LayoutTests/ChangeLog:8 > + * platform/mac-wk2/TestExpectations: Can you add a bit here about what you are doing? Is the test now passing?
Antoine Quint
Comment 8 2021-03-07 12:23:11 PST
(In reply to Sam Weinig from comment #7) > Comment on attachment 422504 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=422504&action=review > > > LayoutTests/ChangeLog:8 > > + * platform/mac-wk2/TestExpectations: > > Can you add a bit here about what you are doing? Is the test now passing? I've been seeing it pass locally for quite some time, and this failure was on Mojave which I think we've dropped support for in ToT. Will check the bots to see how that test has been doing.
Antoine Quint
Comment 9 2021-03-07 12:24:22 PST
The bots are looking good indeed: https://results.webkit.org/?suite=layout-tests&test=webanimations%2Faccelerated-transform-related-animation-property-order.html. I'll add some notes in the ChangeLog!
Antoine Quint
Comment 10 2021-03-07 12:26:31 PST
Committed r274056 (234992@main): <https://commits.webkit.org/234992@main>
Note You need to log in before you can comment on or make changes to this bug.