Bug 219719

Summary: [iOS] TestWebKitAPI.GPUProcess.WebProcessTerminationAfterTooManyGPUProcessCrashes is a flaky failure
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=218811
https://bugs.webkit.org/show_bug.cgi?id=219377
Attachments:
Description Flags
Patch
none
Patch none

Ryan Haddad
Reported 2020-12-09 16:30:12 PST
The following test is a flaky failure on iOS release bots: TestWebKitAPI.GPUProcess.WebProcessTerminationAfterTooManyGPUProcessCrashes ERROR: AudioOutputUnitStart() call failed with error code: -10851 /Volumes/Data/slave/ios-simulator-14-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:198 Value of: [webView _isPlayingAudio] Actual: false Expected: true https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.GPUProcess.WebProcessTerminationAfterTooManyGPUProcessCrashes
Attachments
Patch (2.21 KB, patch)
2020-12-09 16:44 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.62 KB, patch)
2020-12-09 17:42 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2020-12-09 16:31:03 PST
The test was added with https://trac.webkit.org/changeset/269703/webkit
Radar WebKit Bug Importer
Comment 2 2020-12-09 16:31:27 PST
<rdar://problem/72158303>
Chris Dumez
Comment 3 2020-12-09 16:44:15 PST
Created attachment 415812 [details] Patch
Darin Adler
Comment 4 2020-12-09 17:05:04 PST
Comment on attachment 415812 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415812&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:218 > + // FIXME: In the iOS simulator, video resumes after the GPU process crash but audio does not. Comment says simulator, conditional just says iOS.
Chris Dumez
Comment 5 2020-12-09 17:41:15 PST
(In reply to Darin Adler from comment #4) > Comment on attachment 415812 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=415812&action=review > > > Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:218 > > + // FIXME: In the iOS simulator, video resumes after the GPU process crash but audio does not. > > Comment says simulator, conditional just says iOS. Will fix. The issue reproduces on both simulator and device. We just don't run API tests on device AFAIK.
Chris Dumez
Comment 6 2020-12-09 17:42:49 PST
Created attachment 415816 [details] Patch
EWS
Comment 7 2020-12-10 09:17:05 PST
Committed r270628: <https://trac.webkit.org/changeset/270628> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415816 [details].
Note You need to log in before you can comment on or make changes to this bug.