Bug 219560

Summary:

Simplify audio resampling code

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Web Audio

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

219561

Attachments:

Description	Flags
Patch	none
Patch	none

Description Chris Dumez 2020-12-04 16:17:56 PST

Simplify audio resampling code.

Comment 1 Chris Dumez 2020-12-04 16:37:40 PST

Created attachment 415474 [details]
Patch

Comment 2 Darin Adler 2020-12-04 16:43:38 PST

Comment on attachment 415474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415474&action=review

> Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp:124
> +    if (AudioSourceProvider* provider = mediaElement().audioSourceProvider())

I would've used auto here. And I noticed you did use it in a similar case below.

> Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp:172
> +    if (m_multiChannelResampler.get()) {

I don’t think "get()" is needed here.

Comment 3 Chris Dumez 2020-12-04 16:45:57 PST

Created attachment 415475 [details]
Patch

Comment 4 EWS 2020-12-04 17:27:11 PST

Committed r270468: <https://trac.webkit.org/changeset/270468>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415475 [details].

Comment 5 Radar WebKit Bug Importer 2020-12-04 17:28:16 PST

<rdar://problem/72000044>