Bug 219484

Summary: GPU Process: Sandbox violations under IOSurface::maximumSize in the Web Content process
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: pvollan, rniwa, sabouhallawa, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=219492
https://bugs.webkit.org/show_bug.cgi?id=235526
https://bugs.webkit.org/show_bug.cgi?id=221346
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Tim Horton
Reported 2020-12-03 00:59:32 PST
GPU Process: Sandbox violations under IOSurface::maximumSize in the Web Content process
Attachments
Patch (8.61 KB, patch)
2020-12-03 01:00 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (8.63 KB, patch)
2020-12-03 02:28 PST, Tim Horton 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2020-12-03 01:00:35 PST
Created attachment 415282 [details] Patch
Tim Horton
Comment 2 2020-12-03 01:00:38 PST
<rdar://problem/71603808>
Ryosuke Niwa
Comment 3 2020-12-03 02:05:22 PST
Comment on attachment 415282 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415282&action=review > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:248 > + static WTF::Optional<IntSize> maximumSize; > + return maximumSize; Can we assert that this is only called in the main thread?
Tim Horton
Comment 4 2020-12-03 02:28:15 PST
Created attachment 415287 [details] Patch
EWS
Comment 5 2020-12-03 03:10:16 PST
Committed r270392: <https://trac.webkit.org/changeset/270392> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415287 [details].
Alexey Proskuryakov
Comment 6 2020-12-03 07:40:24 PST
Comment on attachment 415287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415287&action=review > Source/WebKit/ChangeLog:17 > + Fetch the maximum allowed size of an IOSurface on the current hardware It will never change when switching between integrated and discrete?
Tim Horton
Comment 7 2020-12-03 07:52:34 PST
I hope not, since we don’t recreate all existing surfaces when that happens. But it’s a good point.
Note You need to log in before you can comment on or make changes to this bug.