Bug 219273

Summary: Have scroll-snap support code use ScrollSnapOffsetsInfo as much as possible
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: ScrollingAssignee: Martin Robinson <mrobinson>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: 077janesmith, annulen, changseok, cmarcelo, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, jamesr, kondapallykalyan, luiz, pdr, ryuan.choi, sergio, simon.fraser, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 219345    
Bug Blocks:    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Description Martin Robinson 2020-11-24 03:46:07 PST 
In the future, WebKit will not use two vectors of offsets to store snap offset info. In order to prepare for this, it can instead pass around the pre-existing SnapOffsetsInfo which abstracts away how snap points are stored. This bug tracks using SnapOffsetsInfo to a greater extent and removing references to "horizontal snap offsets" and "vertical snap offsets."
Comment 2 Martin Robinson 2020-11-26 06:54:26 PST 
Created attachment 414902 [details]
Patch
Comment 3 Martin Robinson 2020-11-26 07:24:31 PST 
Created attachment 414904 [details]
Patch
Comment 4 Martin Robinson 2020-11-26 08:03:04 PST 
Created attachment 414905 [details]
Patch
Comment 5 Martin Robinson 2020-11-26 08:32:21 PST 
Created attachment 414906 [details]
Patch
Comment 6 Martin Robinson 2020-11-27 06:27:33 PST 
Comment on attachment 414906 [details]
Patch

I'm going to split these changes up into smaller pieces that are easier to review. Sorry for the noise.
Comment 7 Radar WebKit Bug Importer 2020-12-01 03:47:19 PST 
<rdar://problem/71844999>
Comment 8 Martin Robinson 2021-01-20 04:42:21 PST 
I'm going to close this metabug in favor of using bug 145157 as the metabug, just to make chasing these a bit easier.
Comment 9 Martin Robinson 2021-01-20 04:42:37 PST 

*** This bug has been marked as a duplicate of bug 145157 ***