| Summary: | [Concurrent display lists] Add a way for display lists to partially replay | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||||
| Component: | WebCore Misc. | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | ews-watchlist, rniwa, sabouhallawa, simon.fraser, thorton, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=219175 | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 218614, 219091, 219097 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Wenson Hsieh
2020-11-17 21:03:55 PST
Created attachment 414411 [details]
Patch
Created attachment 414416 [details]
Fix debug builds
Created attachment 414418 [details]
Rebase on trunk
Created attachment 414486 [details]
Slightly simpler approach
Comment on attachment 414486 [details] Slightly simpler approach View in context: https://bugs.webkit.org/attachment.cgi?id=414486&action=review > Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:154 > + if (destination.isAccelerated()) > + static_cast<AcceleratedRemoteImageBuffer&>(destination).submitDisplayList(*displayList); > + else > + static_cast<UnacceleratedRemoteImageBuffer&>(destination).submitDisplayList(*displayList); This is sad-making. Yeah, it's the same problem in a bunch of places (but, hopefully we can fix them all simultaneously). Comment on attachment 414486 [details] Slightly simpler approach View in context: https://bugs.webkit.org/attachment.cgi?id=414486&action=review >> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:154 >> + static_cast<UnacceleratedRemoteImageBuffer&>(destination).submitDisplayList(*displayList); > > This is sad-making. Yeah, it's not great :( I wanted to try to cast to a RemoteImageBuffer, but that's a templated class. I think that ideally, RemoteRenderingBackend would know about the RemoteImageBuffers it can paint into (instead of always digging it up from the resource cache). Committed r270002: <https://trac.webkit.org/changeset/270002> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414486 [details]. |