Bug 219067 – [Concurrent display lists] Add a way for display lists to partially replay

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Wenson Hsieh]

SSIA

[Wenson Hsieh]

Created attachment 414411 [details]
Patch

[Wenson Hsieh]

Created attachment 414416 [details]
Fix debug builds

[Wenson Hsieh]

Created attachment 414418 [details]
Rebase on trunk

[Wenson Hsieh]

Created attachment 414486 [details]
Slightly simpler approach

[Simon Fraser (smfr)]

Comment on attachment 414486 [details]
Slightly simpler approach

View in context: https://bugs.webkit.org/attachment.cgi?id=414486&action=review

> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:154
> +        if (destination.isAccelerated())
> +            static_cast<AcceleratedRemoteImageBuffer&>(destination).submitDisplayList(*displayList);
> +        else
> +            static_cast<UnacceleratedRemoteImageBuffer&>(destination).submitDisplayList(*displayList);

This is sad-making.

[Tim Horton]

Yeah, it's the same problem in a bunch of places (but, hopefully we can fix them all simultaneously).

[Wenson Hsieh]

Comment on attachment 414486 [details]
Slightly simpler approach

View in context: https://bugs.webkit.org/attachment.cgi?id=414486&action=review

>> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:154
>> +            static_cast<UnacceleratedRemoteImageBuffer&>(destination).submitDisplayList(*displayList);
> 
> This is sad-making.

Yeah, it's not great :(

I wanted to try to cast to a RemoteImageBuffer, but that's a templated class. I think that ideally, RemoteRenderingBackend would know about the RemoteImageBuffers it can paint into (instead of always digging it up from the resource cache).

[EWS]

Committed r270002: <https://trac.webkit.org/changeset/270002>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414486 [details].

[Radar WebKit Bug Importer]

<rdar://problem/71563985>