Bug 219014

Summary: [macOS] Only extend access to the AppleSNBFBUserClient IOKit class if the GPU Process is not used
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, eric.carlson, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 219012    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Brent Fulgham
Reported 2020-11-16 16:47:42 PST
Although we originally thought this was needed for H.264 decoding, testing shows that this class is never used in WebKit flows, and is not needed. We should remove it.
Attachments
Patch (2.79 KB, patch)
2020-11-16 19:57 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (2.61 KB, patch)
2020-12-03 09:37 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2020-11-16 16:47:56 PST
<rdar://problem/70463873>
Brent Fulgham
Comment 2 2020-11-16 19:57:22 PST
Created attachment 414302 [details] Patch
Radar WebKit Bug Importer
Comment 3 2020-11-16 19:58:18 PST
<rdar://problem/71470589>
Brent Fulgham
Comment 4 2020-11-16 20:06:19 PST
This is actually: <rdar://problem/70463873>
EWS
Comment 5 2020-11-17 09:57:07 PST
Committed r269911: <https://trac.webkit.org/changeset/269911> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414302 [details].
Brent Fulgham
Comment 6 2020-11-19 17:19:30 PST
I rolled this change out as part of this <https://trac.webkit.org/changeset/270061>. Instead, we will dynamically extend to WebContent when needed (eventually never), and grant access in GPU Process.
Brent Fulgham
Comment 7 2020-12-03 09:37:33 PST
Created attachment 415306 [details] Patch
Per Arne Vollan
Comment 8 2020-12-03 09:51:16 PST
Comment on attachment 415306 [details] Patch R=me.
EWS
Comment 9 2020-12-03 16:31:48 PST
Committed r270418: <https://trac.webkit.org/changeset/270418> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415306 [details].
Note You need to log in before you can comment on or make changes to this bug.