Bug 219012

Summary: [macOS] Only extend access to the AppleIntelMEUserClient IOKit class if the GPU Process is not used
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, eric.carlson, pvollan, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210616
Bug Depends on:    
Bug Blocks: 219014    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Brent Fulgham 2020-11-16 16:27:48 PST 
Although we originally thought this was needed for H.264 decoding, testing shows that this class is never used in WebKit flows, and is not needed. We should remove it.
Comment 1 Brent Fulgham 2020-11-16 16:28:02 PST 
<rdar://problem/70462796>
Comment 2 Brent Fulgham 2020-11-16 16:29:59 PST 
Created attachment 414290 [details]
Patch
Comment 3 EWS 2020-11-16 19:06:09 PST 
Committed r269890: <https://trac.webkit.org/changeset/269890>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414290 [details].
Comment 4 Brent Fulgham 2020-11-16 19:12:52 PST 
Reopening to attach new patch.
Comment 5 Brent Fulgham 2020-11-16 19:12:53 PST 
Created attachment 414300 [details]
Patch
Comment 6 Brent Fulgham 2020-11-16 19:13:46 PST 
Ignore the above.
Comment 7 Truitt Savell 2020-11-17 15:03:23 PST 
It looks like the changes in https://trac.webkit.org/changeset/269890/webkit

has broken platform/mac/media/encrypted-media/fps-generateRequest.html on Catalina wk2

History:
https://results.webkit.org/?suite=layout-tests&test=platform%2Fmac%2Fmedia%2Fencrypted-media%2Ffps-generateRequest.html

Diff:
--- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/platform/mac/media/encrypted-media/fps-generateRequest-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/platform/mac/media/encrypted-media/fps-generateRequest-actual.txt
@@ -6,6 +6,6 @@
 RUN(session = keys.createSession())
 EXPECTED (session != 'null') OK
 RUN(promise = session.generateRequest("sinf", initData))
-Promise resolved OK
+Promise rejected FAIL
 END OF TEST
Comment 8 Brent Fulgham 2020-11-18 14:54:57 PST 
(In reply to Truitt Savell from comment #7)
> It looks like the changes in https://trac.webkit.org/changeset/269890/webkit
> 
> has broken platform/mac/media/encrypted-media/fps-generateRequest.html on
> Catalina wk2
> 

I'll look into it now. I'm building a local root on Catalina to test. These tests do pass on Big Sur, so I might just need to tighten the version check.
Comment 9 Brent Fulgham 2020-11-19 13:48:02 PST 
I cannot reproduce this failure on a Release Intel MacBook Pro on Catalina, or an Intel MacPro on Big Sur. Perhaps this is hardware-specific.
Comment 10 Brent Fulgham 2020-11-19 14:07:41 PST 
Given that some Intel CPU's require this access to support encrypted media playback, we should extend this dynamically to WebContent if we are not using the GPU Process, and always grant it in the GPU Process.
Comment 11 Brent Fulgham 2020-11-19 17:12:49 PST 
Committed r270061: <https://trac.webkit.org/changeset/270061>
Comment 12 Brent Fulgham 2020-11-19 17:13:09 PST 
(In reply to Brent Fulgham from comment #11)
> Committed r270061: <https://trac.webkit.org/changeset/270061>
I rolled out this bug in the above patch.
Comment 13 Brent Fulgham 2020-12-02 15:41:30 PST 
Created attachment 415254 [details]
Patch
Comment 14 Brent Fulgham 2020-12-02 16:00:36 PST 
Created attachment 415257 [details]
Patch
Comment 15 Brent Fulgham 2020-12-02 16:02:15 PST 
Created attachment 415258 [details]
Patch
Comment 16 Brent Fulgham 2020-12-02 16:03:15 PST 
Comment on attachment 415258 [details]
Patch

Patch was reviewed by Eric Carlson. I'm flagging an updated patch that he reviewed online with me.
Comment 17 EWS 2020-12-02 17:41:18 PST 
Committed r270381: <https://trac.webkit.org/changeset/270381>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415258 [details].