Bug 218711

Summary:

[build.webkit.org] Do not print master environment variables in build steps

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, jbedard, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

175056

Attachments:

Description	Flags
Patch	none

Description Aakash Jain 2020-11-09 08:46:33 PST

We are planning to upgrade build.webkit.org to latest Buildbot. Newer Buildbot (by default) prints all the environment variables of master for any MasterShellCommand command (since https://github.com/buildbot/buildbot/pull/2408). As a side note, we also tried to change the default behavior in https://github.com/buildbot/buildbot/pull/4772, but the PR wasn't accepted.

We should update the MasterShellCommand steps to ensure that we set logEnviron to False.

Comment 1 Aakash Jain 2020-11-09 08:49:08 PST

Created attachment 413589 [details]
Patch

Comment 2 EWS 2020-11-09 15:50:11 PST

Committed r269611: <https://trac.webkit.org/changeset/269611>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413589 [details].

Comment 3 Radar WebKit Bug Importer 2020-11-09 15:51:28 PST

<rdar://problem/71214815>