Bug 218675

Summary: Remove `localBounds` and `globalBounds` methods from display list items that are not drawing items
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebCore Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, sabouhallawa, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 218588    
Bug Blocks:    
Attachments:
Description Flags
Depends on #218588
none
For EWS none

Wenson Hsieh
Reported 2020-11-06 15:41:04 PST
SSIA
Attachments
Depends on #218588 (15.47 KB, patch)
2020-11-06 16:24 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
For EWS (15.66 KB, patch)
2020-11-06 17:30 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-11-06 16:24:48 PST
Created attachment 413497 [details] Depends on #218588
Devin Rousso
Comment 2 2020-11-06 17:23:53 PST
Comment on attachment 413497 [details] Depends on #218588 View in context: https://bugs.webkit.org/attachment.cgi?id=413497&action=review > Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h:160 > + appendWithoutUpdatingExtents<T>(std::forward<Args>(args)...); I think you could do this with `if constexpr` instead of two overloads
Wenson Hsieh
Comment 3 2020-11-06 17:24:25 PST
Comment on attachment 413497 [details] Depends on #218588 I learned from Devin and Andy over Slack that simply wrapping the extent logic in `if constexpr (T::isDrawingItem) { ... }` works here too — I'm going to change it to that instead, since it's a bit cleaner than using std::enable_if.
Wenson Hsieh
Comment 4 2020-11-06 17:30:13 PST
Created attachment 413503 [details] For EWS
EWS
Comment 5 2020-11-06 19:54:04 PST
Committed r269556: <https://trac.webkit.org/changeset/269556> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413503 [details].
Note You need to log in before you can comment on or make changes to this bug.