| Summary: | Remove `localBounds` and `globalBounds` methods from display list items that are not drawing items | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
| Component: | WebCore Misc. | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | hi, sabouhallawa, simon.fraser, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | DoNotImportToRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 218588 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Wenson Hsieh
2020-11-06 15:41:04 PST
Created attachment 413497 [details]
Depends on #218588
Comment on attachment 413497 [details] Depends on #218588 View in context: https://bugs.webkit.org/attachment.cgi?id=413497&action=review > Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h:160 > + appendWithoutUpdatingExtents<T>(std::forward<Args>(args)...); I think you could do this with `if constexpr` instead of two overloads Comment on attachment 413497 [details]
Depends on #218588
I learned from Devin and Andy over Slack that simply wrapping the extent logic in `if constexpr (T::isDrawingItem) { ... }` works here too — I'm going to change it to that instead, since it's a bit cleaner than using std::enable_if.
Created attachment 413503 [details]
For EWS
Committed r269556: <https://trac.webkit.org/changeset/269556> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413503 [details]. |