Bug 218614

Summary: [Concurrent display lists] Support playback of display list items with cached resources
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, rniwa, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 218426, 218649, 219067, 219652, 219657    
Bug Blocks:    
Attachments:
Description Flags
WIP
none
Patch none

Wenson Hsieh
Reported 2020-11-05 07:49:16 PST
e.g. DrawGlyphs, DrawImage, etc.
Attachments
WIP (26.69 KB, patch)
2020-11-05 07:52 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (10.68 KB, patch)
2020-12-08 17:10 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-11-05 07:52:15 PST
Created attachment 413296 [details] WIP
Radar WebKit Bug Importer
Comment 2 2020-11-12 07:50:16 PST
<rdar://problem/71326662>
Wenson Hsieh
Comment 3 2020-12-08 14:27:27 PST
This blocks making daringfireball.net work, with both canvas + DOM GPUP features enabled.
Wenson Hsieh
Comment 4 2020-12-08 17:10:59 PST
Created attachment 415692 [details] Patch
EWS
Comment 5 2020-12-09 11:50:36 PST
Committed r270591: <https://trac.webkit.org/changeset/270591> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415692 [details].
Geoffrey Garen
Comment 6 2020-12-09 11:51:16 PST
It feels kind of complicated for WebContent to send commands and resources out of order, and then rely on GPU Process to stitch them back into order. I wonder if there's a way to ensure that commands always arrive in order with their resources.
Wenson Hsieh
Comment 7 2020-12-09 11:57:19 PST
(In reply to Geoffrey Garen from comment #6) > It feels kind of complicated for WebContent to send commands and resources > out of order, and then rely on GPU Process to stitch them back into order. I > wonder if there's a way to ensure that commands always arrive in order with > their resources. Yeah, I think that we should eventually implement caching for native images and image buffers through display list items (like Ryosuke is doing with fonts in https://bugs.webkit.org/show_bug.cgi?id=219672). I think the underlying mechanism that I introduced to fix this will be generally useful though, for generally synchronizing with other IPC messages.
Ryosuke Niwa
Comment 8 2020-12-09 12:53:15 PST
(In reply to Wenson Hsieh from comment #7) > (In reply to Geoffrey Garen from comment #6) > > It feels kind of complicated for WebContent to send commands and resources > > out of order, and then rely on GPU Process to stitch them back into order. I > > wonder if there's a way to ensure that commands always arrive in order with > > their resources. > > Yeah, I think that we should eventually implement caching for native images > and image buffers through display list items (like Ryosuke is doing with > fonts in https://bugs.webkit.org/show_bug.cgi?id=219672). We need some mechanism to map shared memory from display list if we're going on that route.
Note You need to log in before you can comment on or make changes to this bug.