| Summary: | [Concurrent display lists] Support playback of display list items with cached resources | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
| Component: | WebKit2 | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ggaren, rniwa, simon.fraser, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 218426, 218649, 219067, 219652, 219657 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Wenson Hsieh
2020-11-05 07:49:16 PST
Created attachment 413296 [details]
WIP
This blocks making daringfireball.net work, with both canvas + DOM GPUP features enabled. Created attachment 415692 [details]
Patch
Committed r270591: <https://trac.webkit.org/changeset/270591> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415692 [details]. It feels kind of complicated for WebContent to send commands and resources out of order, and then rely on GPU Process to stitch them back into order. I wonder if there's a way to ensure that commands always arrive in order with their resources. (In reply to Geoffrey Garen from comment #6) > It feels kind of complicated for WebContent to send commands and resources > out of order, and then rely on GPU Process to stitch them back into order. I > wonder if there's a way to ensure that commands always arrive in order with > their resources. Yeah, I think that we should eventually implement caching for native images and image buffers through display list items (like Ryosuke is doing with fonts in https://bugs.webkit.org/show_bug.cgi?id=219672). I think the underlying mechanism that I introduced to fix this will be generally useful though, for generally synchronizing with other IPC messages. (In reply to Wenson Hsieh from comment #7) > (In reply to Geoffrey Garen from comment #6) > > It feels kind of complicated for WebContent to send commands and resources > > out of order, and then rely on GPU Process to stitch them back into order. I > > wonder if there's a way to ensure that commands always arrive in order with > > their resources. > > Yeah, I think that we should eventually implement caching for native images > and image buffers through display list items (like Ryosuke is doing with > fonts in https://bugs.webkit.org/show_bug.cgi?id=219672). We need some mechanism to map shared memory from display list if we're going on that route. |