Bug 218539

Summary:

Link against the ANGLE Shared Library

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ews-watchlist, graouts, kondapallykalyan, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

224532

Attachments:

Description	Flags
Patch	none
Patch	none

Dean Jackson

Reported 2020-11-03 15:36:45 PST

Link against the ANGLE Shared Library

Attachments
Patch (9.73 KB, patch) 2020-11-03 15:42 PST, Dean Jackson	no flags	Details Formatted Diff Diff
Patch (9.65 KB, patch) 2021-03-18 14:15 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dean Jackson

Comment 1 2020-11-03 15:41:33 PST

<rdar://problem/69062211>

Dean Jackson

Comment 2 2020-11-03 15:42:11 PST

Created attachment 413115 [details] Patch

Tim Horton

Comment 3 2020-11-03 16:07:06 PST

Comment on attachment 413115 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413115&action=review > Source/WebCore/Configurations/WebCore.xcconfig:43 > +WK_EMBEDDED_LIBRARY_DIR = $(WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Frameworks "Embedded" reads like old-school "mobile" to me, but I get that you mean "inside". Alas. I think it's fine. > Source/WebCore/Configurations/WebCore.xcconfig:72 > +WK_ANGLE_LDFLAGS = -weak-lANGLE-shared; Is this ... really the right syntax? It looks super weird!

Dean Jackson

Comment 4 2020-11-03 16:09:34 PST

Comment on attachment 413115 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413115&action=review >> Source/WebCore/Configurations/WebCore.xcconfig:43 >> +WK_EMBEDDED_LIBRARY_DIR = $(WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Frameworks > > "Embedded" reads like old-school "mobile" to me, but I get that you mean "inside". Alas. I think it's fine. I guess it could be FRAMEWORKS. >> Source/WebCore/Configurations/WebCore.xcconfig:72 >> +WK_ANGLE_LDFLAGS = -weak-lANGLE-shared; > > Is this ... really the right syntax? It looks super weird! I believe it is. At least.... it's working :)

Dean Jackson

Comment 5 2020-11-03 16:11:56 PST

Committed r269344: <https://trac.webkit.org/changeset/269344>

Dean Jackson

Comment 6 2020-11-19 17:07:03 PST

Reverted in r269364

Dean Jackson

Comment 7 2020-11-19 17:41:42 PST

Committed r270064: <https://trac.webkit.org/changeset/270064>

Ryan Haddad

Comment 8 2020-11-20 09:57:24 PST

Reverted r270064 for reason: Broke the macCatayst build Committed r270121: <https://trac.webkit.org/changeset/270121>