Bug 218469

Summary: Stop building ANGLE source files twice
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: ANGLEAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dino, ews-watchlist, graouts, kondapallykalyan, krollin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225162
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2020-11-02 16:39:31 PST
Stop building ANGLE source files twice. We can build libANGLE.a first, and then use it to link libANGLE-shared.dylib.
Attachments
Patch v1 (84.38 KB, patch)
2020-11-02 16:53 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2020-11-02 16:53:54 PST
Created attachment 412989 [details] Patch v1
EWS Watchlist
Comment 2 2020-11-02 16:54:37 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
David Kilzer (:ddkilzer)
Comment 3 2020-11-02 16:59:48 PST
(In reply to David Kilzer (:ddkilzer) from comment #1) > Created attachment 412989 [details] > Patch v1 I verified that the symbols are identical in libANGLE-shared.dyilb before/after this change.
EWS
Comment 4 2020-11-03 10:46:06 PST
Committed r269315: <https://trac.webkit.org/changeset/269315> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412989 [details].
Radar WebKit Bug Importer
Comment 5 2020-11-03 10:47:44 PST
<rdar://problem/71001669>
Note You need to log in before you can comment on or make changes to this bug.