Bug 218469

Summary: Stop building ANGLE source files twice
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: ANGLEAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dino, ews-watchlist, graouts, kondapallykalyan, krollin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225162
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2020-11-02 16:39:31 PST
Stop building ANGLE source files twice.

We can build libANGLE.a first, and then use it to link libANGLE-shared.dylib.
Comment 1 David Kilzer (:ddkilzer) 2020-11-02 16:53:54 PST
Created attachment 412989 [details]
Patch v1
Comment 2 EWS Watchlist 2020-11-02 16:54:37 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 David Kilzer (:ddkilzer) 2020-11-02 16:59:48 PST
(In reply to David Kilzer (:ddkilzer) from comment #1)
> Created attachment 412989 [details]
> Patch v1

I verified that the symbols are identical in libANGLE-shared.dyilb before/after this change.
Comment 4 EWS 2020-11-03 10:46:06 PST
Committed r269315: <https://trac.webkit.org/changeset/269315>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412989 [details].
Comment 5 Radar WebKit Bug Importer 2020-11-03 10:47:44 PST
<rdar://problem/71001669>