Bug 218333

Summary: Final refactor for WebGL implementation to use only GraphicsContextGL
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, cgarcia, changseok, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, graouts, gustavo, gyuyoung.kim, hi, jer.noble, joepeck, kondapallykalyan, menard, philipj, pnormand, sam, sergio, simon.fraser, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 217211, 218972    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Kimmo Kinnunen 2020-10-29 05:33:14 PDT 
Final refactor for WebGL implementation to use only GraphicsContextGL
Comment 1 Kimmo Kinnunen 2020-10-29 06:00:33 PDT 
Created attachment 412637 [details]
Patch
Comment 2 Kimmo Kinnunen 2020-10-29 07:18:35 PDT 
Created attachment 412643 [details]
Patch
Comment 3 Sam Weinig 2020-10-29 14:48:21 PDT 
Would be a bit easier to review if the unrelated whitespace changes were not part of the change.
Comment 4 Radar WebKit Bug Importer 2020-11-05 04:34:18 PST 
<rdar://problem/71074121>
Comment 5 Kimmo Kinnunen 2020-11-13 01:59:29 PST 
Created attachment 414015 [details]
Patch
Comment 6 Kimmo Kinnunen 2020-11-13 02:35:24 PST 
Created attachment 414021 [details]
Patch
Comment 7 Kimmo Kinnunen 2020-11-13 03:42:23 PST 
Created attachment 414028 [details]
Patch
Comment 8 Kimmo Kinnunen 2020-11-13 04:05:49 PST 
Created attachment 414030 [details]
Patch
Comment 9 Simon Fraser (smfr) 2020-11-13 10:38:15 PST 
Comment on attachment 414030 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414030&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1790
> +    static_cast<GraphicsContextGLOpenGL*>(m_context.get())->compressedTexImage2D(target, level, internalformat, width, height,

I think you should add SPECIALIZE_TYPE_TRAITS macros and use downcast<> for all these casts.
Comment 10 EWS 2020-11-16 01:16:57 PST 
Tools/Scripts/svn-apply failed to apply attachment 414030 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 11 Kimmo Kinnunen 2020-11-16 01:22:22 PST 
Created attachment 414201 [details]
Patch
Comment 12 Kimmo Kinnunen 2020-11-16 01:34:13 PST 
(In reply to Simon Fraser (smfr) from comment #9)

> I think you should add SPECIALIZE_TYPE_TRAITS macros and use downcast<> for
> all these casts.

I filed this as bug 218972, so it doesn't block landing this one. IIUC, this is landable given the r+?

I'd rather first try to remove the code-paths altogether. They're a bit inconvenient to edit as in Apple env we don't compile these at all.
Comment 13 EWS 2020-11-16 04:57:37 PST 
Committed r269850: <https://trac.webkit.org/changeset/269850>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414201 [details].