Bug 218272

Summary: Extend check-for-inappropriate-files-in-framework to WebKitLegacy and JavaScriptCore
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, dino, ews-watchlist, keith_miller, mark.lam, msaboff, saam, simon.fraser, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2020-10-27 19:04:17 PDT
Bug 218268 reports that some *.txt files got included in WebKitLegacy. To help protect against this happening in the future, extend check-for-inappropriate-files-in-framework to check for *.txt files, and apply the script to WebKitLegacy and JavaScriptCore in addition to WebCore and WebKit.
Attachments
Patch (9.07 KB, patch)
2020-11-03 00:01 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-10-27 19:04:29 PDT
<rdar://problem/70748116>
Keith Rollin
Comment 2 2020-10-27 19:55:11 PDT
The patch is done, but I can't upload it until the bots are cleaned of the *.txt files that this patch is supposed to detect.
Keith Rollin
Comment 3 2020-11-02 23:59:33 PST
Added a suggestion from David to manually remove those files so that check-for-inappropriate-files-in-framework won't complain about them.
Keith Rollin
Comment 4 2020-11-03 00:01:02 PST
Created attachment 413010 [details] Patch
EWS
Comment 5 2020-11-03 09:52:34 PST
Committed r269310: <https://trac.webkit.org/changeset/269310> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413010 [details].
Note You need to log in before you can comment on or make changes to this bug.