Bug 218057

Summary: Turn ScriptExecutionContext::vm() into a pure virtual function
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, ggaren, kangil.han, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=218028
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2020-10-21 16:08:59 PDT
Turn ScriptExecutionContext::vm() into a pure virtual function instead of using a non-virtual function that does type-checking inside.
Attachments
Patch (6.15 KB, patch)
2020-10-21 16:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-10-21 16:10:04 PDT
Created attachment 412043 [details] Patch
Geoffrey Garen
Comment 2 2020-10-21 16:17:14 PDT
Comment on attachment 412043 [details] Patch r=me
EWS
Comment 3 2020-10-22 09:23:13 PDT
Committed r268868: <https://trac.webkit.org/changeset/268868> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412043 [details].
Radar WebKit Bug Importer
Comment 4 2020-10-22 09:24:18 PDT
<rdar://problem/70576507>
Note You need to log in before you can comment on or make changes to this bug.