Summary: | Remove use of in-makefile grepping of FEATURE_AND_PLATFORM_DEFINES | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||
Component: | WebCore Misc. | Assignee: | Sam Weinig <sam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | calvaris, cdumez, changseok, darin, dbarton, eric.carlson, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, jer.noble, macpherson, menard, philipj, sergio, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Sam Weinig
2020-10-20 16:08:21 PDT
Created attachment 411935 [details]
Patch
*** Bug 218000 has been marked as a duplicate of this bug. *** Comment on attachment 411935 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411935&action=review > Source/WebCore/DerivedSources.make:1277 > + GestureEvent.idl \ I suggest sorting this in alphabetically. Created attachment 412034 [details]
Patch
Created attachment 412035 [details]
Patch
Comment on attachment 412035 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412035&action=review > Source/WebCore/ChangeLog:14 > + Remove conditionalized additions to ADDITIONAL_BINDING_IDLS and just always add > + the concrete set, relying on the existing extended attributes in the IDLs instead. Is it the call to "realpath" that helps us cleanly remove any files that don’t exist? (In reply to Darin Adler from comment #6) > Comment on attachment 412035 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=412035&action=review > > > Source/WebCore/ChangeLog:14 > > + Remove conditionalized additions to ADDITIONAL_BINDING_IDLS and just always add > > + the concrete set, relying on the existing extended attributes in the IDLs instead. > > Is it the call to "realpath" that helps us cleanly remove any files that > don’t exist? I think so. The Make documentation says: $(realpath names…) For each file name in names return the canonical absolute name. A canonical name does not contain any . or .. components, nor any repeated path separators (/) or symlinks. In case of a failure the empty string is returned. Comment on attachment 412035 [details]
Patch
r=me assuming this passes tests
(Now I should revive the branch where I was doing the file thing, or let you do it over again [either is OK with me]. Hardest part seemed to be the xcfilelist bit.) Committed r268849: <https://trac.webkit.org/changeset/268849> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412035 [details]. |