Bug 217950

Summary: WebDriver: handle key events with non-ASCII unicode code point
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebDriverAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bburg, clopez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 166679, 217951    
Attachments:
Description Flags
Patch clopez: review+

Carlos Garcia Campos
Reported 2020-10-20 06:05:58 PDT
We are assuming that key events are limited to ASCII, but they contain a unicode code point. This makes several tests to fail: imported/w3c/webdriver/tests/perform_actions/key_events.py::test_printable_key_sends_correct_events[\xe0-] imported/w3c/webdriver/tests/perform_actions/key_events.py::test_printable_key_sends_correct_events[\u0416-] imported/w3c/webdriver/tests/perform_actions/key_events.py::test_printable_key_sends_correct_events[\u2603-] imported/w3c/webdriver/tests/perform_actions/key_events.py::test_printable_key_sends_correct_events[\uf6c2-]
Attachments
Patch (5.83 KB, patch)
2020-10-20 06:09 PDT, Carlos Garcia Campos 		clopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-10-20 06:09:20 PDT
Created attachment 411858 [details] Patch I've remove the test expectations, but those tests are still failing due to https://github.com/web-platform-tests/wpt/pull/26183
Radar WebKit Bug Importer
Comment 2 2020-10-20 08:57:52 PDT
<rdar://problem/70487022>
Carlos Garcia Campos
Comment 3 2020-10-22 02:42:29 PDT
Committed r268858: <https://trac.webkit.org/changeset/268858>
Note You need to log in before you can comment on or make changes to this bug.