Bug 217914

Summary: [ews] use -o while unzipping layout-test-results.zip
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: jbedard, lingcherd_ho, lingho, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 175056    
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2020-10-19 11:26:03 PDT
We should use -o flag while unzipping layout-test-results.zip in EWS to improve unzip performance.
Attachments
Patch (3.36 KB, patch)
2020-10-19 11:41 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-10-19 11:41:51 PDT
Created attachment 411767 [details] Patch
Jonathan Bedard
Comment 2 2020-10-19 11:52:33 PDT
Comment on attachment 411767 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411767&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:2740 > unzip says that -o overwrites files without prompting....how did we get away with this in the first place?
Aakash Jain
Comment 3 2020-10-19 11:58:07 PDT
In case of EWS, the file shouldn't exist previously. The uploaded file name is unique for each build.
Ling Ho
Comment 4 2020-10-19 13:27:25 PDT
This is to eliminate the unecessary four lstat and stat calls everytime a file is getting extracted. But I haven't verified if -o indeed does that. Aakash have you?
EWS
Comment 5 2020-10-19 14:35:47 PDT
Committed r268689: <https://trac.webkit.org/changeset/268689> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411767 [details].
Radar WebKit Bug Importer
Comment 6 2020-10-19 14:36:19 PDT
<rdar://problem/70456769>
Ling Ho
Comment 7 2020-10-19 14:38:43 PDT
Looks like adding -o won't help. Unzip is still calling lstat and stat (twice each) before creating a file. So don't expect any performance improvement.
Aakash Jain
Comment 8 2020-10-26 10:27:05 PDT
Discussed with Ling offline. As per him: I guess there is no harm leaving -o there. Might be the right thing to do because if for whatever reason the files were there before, we should overwrite.
Note You need to log in before you can comment on or make changes to this bug.