Bug 217488 – [LFC][Integration] Enable overflow hidden

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

ssia

[alan]

Created attachment 410870 [details]
Patch

[alan]

Created attachment 410926 [details]
Patch

[Antti Koivisto]

Comment on attachment 410926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410926&action=review

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:198
> +        SET_REASON_AND_RETURN_IF_NEEDED(FlowHasOverflowNotVisible, reasons, includeReasons);

Can you also remove FlowHasOverflowNotVisible enum value?

[Antti Koivisto]

> Can you also remove FlowHasOverflowNotVisible enum value?

Oh I guess not since it just moves.

[alan]

(In reply to Antti Koivisto from comment #4)
> > Can you also remove FlowHasOverflowNotVisible enum value?
> 
> Oh I guess not since it just moves.
Yea we still have the auto/scroll case here.

[alan]

Created attachment 410978 [details]
Patch

[EWS]

Committed r268294: <https://trac.webkit.org/changeset/268294>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410978 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70157279>

[Aakash Jain]

This (In reply to EWS from comment #7)
> Committed r268294: <https://trac.webkit.org/changeset/268294>
This seems to have broken a test on ios-wk2: imported/blink/fast/css/zoomed-intrinsic-width.html 

EWS also indicated this failure in https://ews-build.webkit.org/#/builders/24/builds/27791. Should have waited for ews to complete before cq+ing the patch.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 217608

[Aakash Jain]

History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fblink%2Ffast%2Fcss%2Fzoomed-intrinsic-width.html