Bug 217475

Summary:

[Mac] imported/w3c/web-platform-tests/css/css-pseudo/text-selection.html is failing

Product:

WebKit

Reporter:

Oriol Brufau <obrufau>

Component:

Tools / Tests

Assignee:

Oriol Brufau <obrufau>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, hector_i_lopez, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

167729

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Description Oriol Brufau 2020-10-08 07:26:36 PDT

imported/w3c/web-platform-tests/css/css-pseudo/text-selection.html was already flaky (bug 217161).
But bug 167729 made it worse.

Before r267940, the expectation for the test in all platforms was (1):

FAIL Selection ending in ::before assert_equals: toString expected "hello" but got ""
PASS Selection contained in ::before
FAIL Selection ending in ::marker assert_equals: toString expected "hello" but got ""
PASS Selection contained in ::marker
FAIL Selection ending in ::before-marker assert_equals: toString expected "hello" but got ""
PASS Selection contained in ::before-marker

But in r267940 I added a different expectation for Mac (2):

FAIL Selection ending in ::before assert_equals: toString expected "hello" but got ""
PASS Selection contained in ::before
FAIL Selection ending in ::marker assert_equals: toString expected "hello" but got ""
PASS Selection contained in ::marker
FAIL Selection ending in ::before-marker assert_equals: toString expected "hello" but got ""
FAIL Selection contained in ::before-marker assert_equals: toString expected "" but got "h"

But this made it fail in Mac Catalina, which was producing (1).

So r268171 changed the Mac expectation to match (1).
But this made the test fail in Mac Mojave, which was expecting (2).

Then, it seems:
 - LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/text-selection-expected.txt should keep having (1).
 - LayoutTests/platform/mac/imported/w3c/web-platform-tests/css/css-pseudo/text-selection-expected.txt should be removed.
 - LayoutTests/platform/mac-mojave/imported/w3c/web-platform-tests/css/css-pseudo/text-selection-expected.txt should be created with (2).

Comment 1 Oriol Brufau 2020-10-08 07:36:24 PDT

Created attachment 410839 [details]
Patch

Comment 2 Oriol Brufau 2020-10-08 07:37:50 PDT

The test results can be seen here:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-pseudo%2Ftext-selection.html

Comment 3 Oriol Brufau 2020-10-08 09:42:23 PDT

Created attachment 410850 [details]
Patch

Comment 4 EWS 2020-10-09 18:36:28 PDT

Tools/Scripts/svn-apply failed to apply attachment 410850 [details] to trunk.
Please resolve the conflicts and upload a new patch.

Comment 5 Oriol Brufau 2020-10-09 18:53:57 PDT

Created attachment 410993 [details]
Patch

Comment 6 Oriol Brufau 2020-10-09 19:05:36 PDT

Created attachment 410995 [details]
Patch

Comment 7 EWS 2020-10-10 05:50:56 PDT

Committed r268310: <https://trac.webkit.org/changeset/268310>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410995 [details].

Comment 8 Radar WebKit Bug Importer 2020-10-10 05:51:20 PDT

<rdar://problem/70170520>