Bug 217213

Summary: Refactor WebGL implementation to use only GraphicsContextGL part 1
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, cmarcelo, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, koivisto, kondapallykalyan, luiz, noam, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Mac   
OS: Unspecified   
Bug Depends on: 217212, 217374    
Bug Blocks: 217211, 217216    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
dino: review+
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch ews-feeder: commit-queue-

Description Kimmo Kinnunen 2020-10-02 04:20:00 PDT 
Refactor WebGL implementation to use only GraphicsContextGL

Current implementation uses GraphicsContextGLOpenGL. This cannot support remote WebGL
Comment 1 Radar WebKit Bug Importer 2020-10-02 04:20:42 PDT 
<rdar://problem/69876105>
Comment 2 Kimmo Kinnunen 2020-10-14 05:59:45 PDT 
Created attachment 411315 [details]
Patch
Comment 3 Kimmo Kinnunen 2020-10-14 06:03:36 PDT 
Created attachment 411317 [details]
Patch
Comment 4 Kimmo Kinnunen 2020-10-14 11:45:31 PDT 
Created attachment 411353 [details]
Patch
Comment 5 Kimmo Kinnunen 2020-10-15 05:48:17 PDT 
Created attachment 411433 [details]
Patch
Comment 6 Dean Jackson 2020-10-15 15:50:21 PDT 
Comment on attachment 411353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411353&action=review

> Source/WebCore/ChangeLog:24
> +        Introduce a virtual member fuction in GraphicsContextGL for

typo function
Comment 7 Kimmo Kinnunen 2020-10-15 23:50:16 PDT 
Created attachment 411539 [details]
Patch
Comment 8 EWS 2020-10-16 01:18:32 PDT 
kkinnunen@apple.com does not have reviewer permissions according to https://svn.webkit.org/repository/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

Rejecting attachment 411539 [details] from commit queue.
Comment 9 EWS 2020-10-16 03:56:05 PDT 
Committed r268578: <https://trac.webkit.org/changeset/268578>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411539 [details].
Comment 10 Kimmo Kinnunen 2020-10-16 03:57:13 PDT 
patches still left
Comment 11 Kimmo Kinnunen 2020-10-16 04:18:30 PDT 
Created attachment 411554 [details]
Patch
Comment 12 Kimmo Kinnunen 2020-10-16 04:25:01 PDT 
Created attachment 411555 [details]
Patch
Comment 13 Kimmo Kinnunen 2020-10-16 04:28:59 PDT 
Created attachment 411556 [details]
Patch
Comment 14 Kimmo Kinnunen 2020-10-16 04:37:17 PDT 
Created attachment 411557 [details]
Patch