Bug 216989

Summary: Avoid having to call context.lazyInitialize() in every AudioNode factory function
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 216988    
Bug Blocks: 212611, 216994    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2020-09-25 13:06:22 PDT
Avoid having to call context.lazyInitialize() in every AudioNode factory function. Replace all these calls with a single one inside the AudioNode constructor.
Attachments
Patch (17.65 KB, patch)
2020-09-25 13:12 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (17.35 KB, patch)
2020-09-25 16:12 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-09-25 13:12:33 PDT
Created attachment 409728 [details] Patch
Chris Dumez
Comment 2 2020-09-25 16:12:44 PDT
Created attachment 409755 [details] Patch
Darin Adler
Comment 3 2020-09-25 16:30:09 PDT
Comment on attachment 409728 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409728&action=review > Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:233 > + if (!isOfflineContext()) > + ++s_hardwareContextCount; Change log doesn’t mention this change.
Chris Dumez
Comment 4 2020-09-25 16:31:22 PDT
(In reply to Darin Adler from comment #3) > Comment on attachment 409728 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409728&action=review > > > Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:233 > > + if (!isOfflineContext()) > > + ++s_hardwareContextCount; > > Change log doesn’t mention this change. Yes, this was a left over change I did not mean to upload. This is why I uploaded another iteration.
EWS
Comment 5 2020-09-25 17:02:03 PDT
Committed r267609: <https://trac.webkit.org/changeset/267609> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409755 [details].
Radar WebKit Bug Importer
Comment 6 2020-09-25 17:03:17 PDT
<rdar://problem/69601798>
Note You need to log in before you can comment on or make changes to this bug.