Summary: | Avoid having to call context.lazyInitialize() in every AudioNode factory function | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 216988 | ||||||||
Bug Blocks: | 212611, 216994 | ||||||||
Attachments: |
|
Description
Chris Dumez
2020-09-25 13:06:22 PDT
Created attachment 409728 [details]
Patch
Created attachment 409755 [details]
Patch
Comment on attachment 409728 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409728&action=review > Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:233 > + if (!isOfflineContext()) > + ++s_hardwareContextCount; Change log doesn’t mention this change. (In reply to Darin Adler from comment #3) > Comment on attachment 409728 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409728&action=review > > > Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:233 > > + if (!isOfflineContext()) > > + ++s_hardwareContextCount; > > Change log doesn’t mention this change. Yes, this was a left over change I did not mean to upload. This is why I uploaded another iteration. Committed r267609: <https://trac.webkit.org/changeset/267609> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409755 [details]. |