Bug 216898

Summary: [build.webkit.org] Add unit-test to detect invalid triggers in config.json
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=216658
Attachments:
Description Flags
Patch
none
Patch none

Aakash Jain
Reported 2020-09-23 14:40:38 PDT
[build.webkit.org] We should add unit-test to detect invalid triggers in config.json, especially when the builder which is being triggered by the trigger doesn't exist.
Attachments
Patch (5.03 KB, patch)
2020-09-29 06:40 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (4.79 KB, patch)
2020-09-29 07:04 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-09-29 06:39:26 PDT
This is to prevent issues like https://bugs.webkit.org/show_bug.cgi?id=216658#c15
Aakash Jain
Comment 2 2020-09-29 06:40:12 PDT
Turns out that we don't have any unit-test for build.webkit.org for testing config.json
Aakash Jain
Comment 3 2020-09-29 06:40:33 PDT
Created attachment 409994 [details] Patch
Aakash Jain
Comment 4 2020-09-29 06:45:51 PDT
(In reply to Aakash Jain from comment #3) > Created attachment 409994 [details] > Patch This is mostly copied from https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py Long term aim is to have almost same unit-tests testing both EWS and build.webkit.org, but that would need various changes (especially because of different Buildbot versions) and would be done incrementally.
Aakash Jain
Comment 5 2020-09-29 07:04:19 PDT
Created attachment 409996 [details] Patch
EWS
Comment 6 2020-09-29 09:02:13 PDT
Committed r267736: <https://trac.webkit.org/changeset/267736> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409996 [details].
Radar WebKit Bug Importer
Comment 7 2020-09-29 09:03:18 PDT
<rdar://problem/69749470>
Note You need to log in before you can comment on or make changes to this bug.