Bug 216875

Summary: Root node with stateless wheel event is not always canHandleWheelEvent
Product: WebKit Reporter: cathiechen <cathiechen>
Component: ScrollingAssignee: cathiechen <cathiechen>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=216609
Attachments:
Description Flags
Patch
none
Patch none

cathiechen
Reported 2020-09-23 06:12:23 PDT
This bug is split from bug 216609
Attachments
Patch (1.90 KB, patch)
2020-09-23 06:17 PDT, cathiechen 		no flags
DetailsFormatted DiffDiff
Patch (1.82 KB, patch)
2020-09-24 01:27 PDT, cathiechen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
cathiechen
Comment 1 2020-09-23 06:17:39 PDT
Created attachment 409468 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-09-23 13:13:17 PDT
Comment on attachment 409468 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409468&action=review > Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:148 > + if (isLatchedNode() || (isRootNode() && !(wheelEvent.phase() == PlatformWheelEventPhaseNone && wheelEvent.momentumPhase() == PlatformWheelEventPhaseNone))) This should use isNonGestureEvent()
cathiechen
Comment 3 2020-09-24 01:26:36 PDT
Comment on attachment 409468 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409468&action=review >> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:148 >> + if (isLatchedNode() || (isRootNode() && !(wheelEvent.phase() == PlatformWheelEventPhaseNone && wheelEvent.momentumPhase() == PlatformWheelEventPhaseNone))) > > This should use isNonGestureEvent() Done, thanks!
cathiechen
Comment 4 2020-09-24 01:27:43 PDT
Created attachment 409540 [details] Patch
EWS
Comment 5 2020-09-24 05:52:40 PDT
Committed r267527: <https://trac.webkit.org/changeset/267527> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409540 [details].
Radar WebKit Bug Importer
Comment 6 2020-09-24 05:53:18 PDT
<rdar://problem/69498046>
Note You need to log in before you can comment on or make changes to this bug.