Summary: | Implement the CSS math-style property | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||||
Component: | CSS | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | changseok, darin, dbarton, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, kondapallykalyan, macpherson, menard, pdr, rbuis, rwlbuis, simon.fraser, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | Other | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
See Also: | https://bugzilla.mozilla.org/show_bug.cgi?id=1665975 | ||||||||||||||||
Bug Depends on: | 216871 | ||||||||||||||||
Bug Blocks: | 195797, 202303 | ||||||||||||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2020-09-18 10:04:26 PDT
Created attachment 409348 [details]
WIP Patch
Created attachment 409665 [details]
WIP Patch
Created attachment 409675 [details]
Patch
Created attachment 409680 [details]
Patch
@rbuis: Please review the MathML part. @Simon: Please review the CSS part, in particular do you it is worth guarding the new math-style property under a preference? Would that still allow to make the property usable internally when the flag is disabled? Comment on attachment 409680 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409680&action=review > Source/WebCore/ChangeLog:18 > + [2]https://github.com/w3c/csswg-drafts/issues/5387 Add space. > Source/WebCore/ChangeLog:36 > + (mtable): Not sure if these are needed, it is allowed to edit exact changes out of ChangeLogs. Created attachment 409685 [details]
Patch
Comment on attachment 409685 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409685&action=review > Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:149 > bool RenderMathMLUnderOver::shouldMoveLimits() Can this function be const? Comment on attachment 409685 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409685&action=review >> Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:149 >> bool RenderMathMLUnderOver::shouldMoveLimits() > > Can this function be const? Right, it can. will do that. Created attachment 409704 [details]
Patch
Committed r267578: <https://trac.webkit.org/changeset/267578> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409704 [details]. Comment on attachment 409680 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409680&action=review >> Source/WebCore/ChangeLog:36 >> + (mtable): > > Not sure if these are needed, it is allowed to edit exact changes out of ChangeLogs. Here’s another way to say this: The scripts that prepare change logs are there to help contributors write a good change logs. But the person submitting the patch is still the author, not the script. Constributors should feel free to edit to make the log good, correct, and intentional. This is difficult, though, if a contributor does not "buy in" to the way the WebKit project does change logs. If someone doesn’t then they probably will think of this as boilerplate, or unnecessary garbage, and likely leave it as is without even looking it over. The idea when the project began, inherited from past open source projects, was to write a per-function comment to help clarify what the change is doing and why. But it seems that few people think that’s worthwhile at this point. So maybe we will change our approach. |