Bug 216871 - Resync WPT's mathml and math-script-level-and-math-style tests
Summary: Resync WPT's mathml and math-script-level-and-math-style tests
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on:
Blocks: 216702
  Show dependency treegraph
 
Reported: 2020-09-23 02:51 PDT by Frédéric Wang (:fredw)
Modified: 2020-09-25 17:53 PDT (History)
11 users (show)

See Also:


Attachments
WIP Patch (800.61 KB, patch)
2020-09-23 02:52 PDT, Frédéric Wang (:fredw)
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (892.91 KB, patch)
2020-09-23 07:07 PDT, Frédéric Wang (:fredw)
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (1.02 MB, patch)
2020-09-23 10:51 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (1.16 MB, patch)
2020-09-23 11:56 PDT, Frédéric Wang (:fredw)
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (1.25 MB, patch)
2020-09-24 01:08 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (1.30 MB, patch)
2020-09-24 02:52 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (1.30 MB, patch)
2020-09-24 03:15 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (1.30 MB, patch)
2020-09-24 04:28 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (1.30 MB, patch)
2020-09-24 06:00 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch for landing (1.30 MB, patch)
2020-09-24 07:42 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch for landing (1.30 MB, patch)
2020-09-24 07:49 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2020-09-23 02:51:07 PDT
.
Comment 1 Frédéric Wang (:fredw) 2020-09-23 02:52:20 PDT
Created attachment 409456 [details]
WIP Patch
Comment 2 Frédéric Wang (:fredw) 2020-09-23 07:07:01 PDT
Created attachment 409471 [details]
Patch
Comment 3 Frédéric Wang (:fredw) 2020-09-23 10:51:33 PDT
Created attachment 409483 [details]
Patch
Comment 4 Frédéric Wang (:fredw) 2020-09-23 11:56:21 PDT
Created attachment 409491 [details]
Patch
Comment 5 Frédéric Wang (:fredw) 2020-09-24 01:08:38 PDT
Created attachment 409538 [details]
Patch
Comment 6 Frédéric Wang (:fredw) 2020-09-24 02:52:08 PDT
Created attachment 409548 [details]
Patch
Comment 7 Rob Buis 2020-09-24 03:09:47 PDT
Comment on attachment 409548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409548&action=review

> LayoutTests/imported/w3c/web-platform-tests/mathml/tools/utils/__pycache__/w3c-import.log:22
> +/LayoutTests/imported/w3c/web-platform-tests/mathml/tools/utils/__pycache__/misc.cpython-38.pyc

Is this part intended?
Comment 8 Frédéric Wang (:fredw) 2020-09-24 03:10:49 PDT
Comment on attachment 409548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409548&action=review

>> LayoutTests/imported/w3c/web-platform-tests/mathml/tools/utils/__pycache__/w3c-import.log:22
>> +/LayoutTests/imported/w3c/web-platform-tests/mathml/tools/utils/__pycache__/misc.cpython-38.pyc
> 
> Is this part intended?

probably not, it's likely a bug in the importer.
Comment 9 Frédéric Wang (:fredw) 2020-09-24 03:15:41 PDT
Created attachment 409549 [details]
Patch
Comment 10 Frédéric Wang (:fredw) 2020-09-24 04:28:02 PDT
Created attachment 409551 [details]
Patch
Comment 11 Frédéric Wang (:fredw) 2020-09-24 06:00:14 PDT
Created attachment 409565 [details]
Patch
Comment 12 EWS 2020-09-24 07:36:49 PDT
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Comment 13 Frédéric Wang (:fredw) 2020-09-24 07:42:23 PDT
Created attachment 409576 [details]
Patch for landing
Comment 14 EWS 2020-09-24 07:43:20 PDT
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Comment 15 Frédéric Wang (:fredw) 2020-09-24 07:49:45 PDT
Created attachment 409577 [details]
Patch for landing
Comment 16 EWS 2020-09-24 08:20:36 PDT
Committed r267531: <https://trac.webkit.org/changeset/267531>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409577 [details].
Comment 17 Radar WebKit Bug Importer 2020-09-24 08:21:22 PDT
<rdar://problem/69504216>
Comment 18 Lauro Moura 2020-09-24 14:59:44 PDT
GTK/WPE baselines updated in r267547.

Some tests seems to be slightly flaky in WPE. Will keep an eye on the results in the bots.
Comment 19 Hector Lopez 2020-09-25 11:58:17 PDT
imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-006.html
imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001.html	

Tests are both missing testing results on macOS wk2. It looks baselines are missing for macOS wk2 from https://trac.webkit.org/changeset/267531/webkit.

History:

https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fmathml%2Fpresentation-markup%2Foperators%2Foperator-dictionary-stretchy-006.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fmathml%2Fpresentation-markup%2Foperators%2Foperator-dictionary-symmetric-001.html

Results:
imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-006.html:


PASS Operator dictionary chunk 1 - stretchy 
PASS Operator dictionary chunk 2 - stretchy 
PASS Operator dictionary chunk 3 - stretchy 
PASS Operator dictionary chunk 4 - stretchy 
PASS Operator dictionary chunk 5 - stretchy 

imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001.html


PASS Operator dictionary chunk 1 - symmetric 
PASS Operator dictionary chunk 2 - symmetric 
PASS Operator dictionary chunk 3 - symmetric 
PASS Operator dictionary chunk 4 - symmetric 
PASS Operator dictionary chunk 5 - symmetric
Comment 20 Frédéric Wang (:fredw) 2020-09-25 17:53:30 PDT
(In reply to Hector Lopez from comment #19)
> imported/w3c/web-platform-tests/mathml/presentation-markup/operators/
> operator-dictionary-stretchy-006.html
> imported/w3c/web-platform-tests/mathml/presentation-markup/operators/
> operator-dictionary-symmetric-001.html	
> 
> Tests are both missing testing results on macOS wk2. It looks baselines are
> missing for macOS wk2 from https://trac.webkit.org/changeset/267531/webkit.
> 

Right, I don't know what happened with these expectations and why EWS didn't detect it. Anyway, I've landed them in https://trac.webkit.org/changeset/267578/webkit since that was detected by EWS there.