Bug 216609

Summary:

Fixed some corner cases of scrolling

Product:

WebKit

Reporter:

cathiechen <cathiechen>

Component:

Scrolling

Assignee:

cathiechen <cathiechen>

Status:

NEW

Severity:

Normal

CC:

ahmad.saleem792, cmarcelo, ews-watchlist, fred.wang, herr.ernst, jamesr, luiz, simon.fraser, tonikitoo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=216870
https://bugs.webkit.org/show_bug.cgi?id=216875

Attachments:

Description	Flags
Patch	simon.fraser: review+

cathiechen

Reported 2020-09-16 07:29:31 PDT

Fixed some corner cases of scrolling.

Attachments
Patch (5.66 KB, patch) 2020-09-16 07:36 PDT, cathiechen	simon.fraser: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

cathiechen

Comment 1 2020-09-16 07:36:52 PDT

Created attachment 408922 [details] Patch

cathiechen

Comment 2 2020-09-16 08:33:28 PDT

Hi Simon and Fred, This patch fixes some corner case I met while implementing scrollend event. I think it'd good to have a separating bug to fix these for the scrollend patch is getting big now. Please take a look, thanks:)

Simon Fraser (smfr)

Comment 3 2020-09-16 09:34:25 PDT

Comment on attachment 408922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408922&action=review > Source/WebCore/ChangeLog:3 > + Fixed some corner cases of scrolling This is a bit vague. Maybe it indicates that this patch should really be separated. Are any of these fixes testable?

cathiechen

Comment 4 2020-09-17 00:49:04 PDT

Comment on attachment 408922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408922&action=review Hi Simon, Thanks for the review:) >> Source/WebCore/ChangeLog:3 >> + Fixed some corner cases of scrolling > > This is a bit vague. Maybe it indicates that this patch should really be separated. > > Are any of these fixes testable? Yeah, I think it's a good idea to split them. These fixes are not very related. I couldn't find a good tile for them. Regarding the test, maybe we can create one for user scroll interrupt the programmatic scroll animation. Others seem not easy to test, for they only effect the internal state.

Radar WebKit Bug Importer

Comment 5 2020-09-23 07:30:14 PDT

<rdar://problem/69434613>

Ahmad Saleem

Comment 6 2023-02-18 03:27:16 PST

It seems this r+ patch didn’t landed, do we need to fix these issues now?

Simon Fraser (smfr)

Comment 7 2023-02-18 11:46:49 PST

I think we do want these, but the patch needs splitting up, and some tests written.

cathiechen

Comment 8 2023-02-20 04:01:04 PST

Ah, ok, let me take a look at it today:)

Ahmad Saleem

Comment 9 2024-10-12 06:07:33 PDT

Partially done in https://commits.webkit.org/229661@main

Note You need to log in before you can comment on or make changes to this bug.