Bug 216577

Summary: [css-flex] Remove flexbox's specific computePreferredLogicalWidths()
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, darin, esprehn+autocc, ews-watchlist, glenn, jer.noble, kondapallykalyan, pdr, rwlbuis, svillar, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=216770
Attachments:
Description Flags
Patch
darin: review+, ews-feeder: commit-queue-
Patch none

Sergio Villar Senin
Reported 2020-09-15 12:55:06 PDT
[css-flex] Remove flexbox's specific computePreferredLogicalWidths()
Attachments
Patch (9.11 KB, patch)
2020-09-15 13:05 PDT, Sergio Villar Senin 		darin: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (6.95 KB, patch)
2020-09-16 04:53 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2020-09-15 13:05:58 PDT
Created attachment 408850 [details] Patch
Sergio Villar Senin
Comment 2 2020-09-16 04:53:48 PDT
Created attachment 408912 [details] Patch
Sergio Villar Senin
Comment 3 2020-09-16 07:37:08 PDT
I was removing too much code. The one in RenderBlock is ankward but we should leave it untouched until it isn't properly fixed in flexbox.
Sergio Villar Senin
Comment 4 2020-09-17 01:01:15 PDT
Committed r267183: <https://trac.webkit.org/changeset/267183>
Radar WebKit Bug Importer
Comment 5 2020-09-17 01:02:16 PDT
<rdar://problem/69049162>
Note You need to log in before you can comment on or make changes to this bug.