Bug 216469

Summary: [TestRunnerShared] Add a new class UIScriptControllerCommon to implement UIScriptController::windowIsKey and UIScriptController::setWindowIsKey
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Tools / TestsAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, darin, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Fujii Hironori
Reported 2020-09-13 19:50:46 PDT
[TestRunnerShared] Make UIScriptController::windowIsKey and UIScriptController::setWindowIsKey virtual I'd like to make TestRunnerShared as a standalone library which doesn't depend on DRT and WTR (Bug 216465). Those methods were added by r263979.
Attachments
Patch (21.30 KB, patch)
2020-09-13 19:58 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (25.04 KB, patch)
2020-09-13 21:20 PDT, Fujii Hironori 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (26.40 KB, patch)
2020-09-13 22:01 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (26.49 KB, patch)
2020-09-14 13:33 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-09-13 19:58:29 PDT
Created attachment 408674 [details] Patch
Fujii Hironori
Comment 2 2020-09-13 21:20:27 PDT
Created attachment 408680 [details] Patch
Fujii Hironori
Comment 3 2020-09-13 22:01:57 PDT
Created attachment 408681 [details] Patch
Fujii Hironori
Comment 4 2020-09-14 13:33:58 PDT
Created attachment 408742 [details] Patch
Darin Adler
Comment 5 2020-09-15 12:52:47 PDT
Comment on attachment 408742 [details] Patch Seems OK. I have a huge patch with lots of simplifications to TestRunnerShared that I better land soon.
Fujii Hironori
Comment 6 2020-09-15 17:23:05 PDT
Comment on attachment 408742 [details] Patch Clearing flags on attachment: 408742 Committed r267120: <https://trac.webkit.org/changeset/267120>
Fujii Hironori
Comment 7 2020-09-15 17:23:09 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-09-15 17:24:21 PDT
<rdar://problem/68952059>
Note You need to log in before you can comment on or make changes to this bug.