Summary: | REGRESSION (r266817): ASSERTION FAILED: injectedBundle.isTestRunning() on imported/w3c/web-platform-tests/service-workers/service-worker/svg-target-reftest.https.html | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
Component: | Tools / Tests | Assignee: | Darin Adler <darin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | clopez, darin, ews-watchlist, sam, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=186045 https://bugs.webkit.org/show_bug.cgi?id=210375 |
||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 216428 | ||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2020-09-12 10:47:26 PDT
Can fix by adding: if (!testRunning) return; To dumpAfterWaitAttributeIsRemoved. When I run this in the debugger, instead of a crash I get a hang. (In reply to Darin Adler from comment #2) > When I run this in the debugger, instead of a crash I get a hang. Oh, never mind, that’s because I was trying to run from a local file instead of with the WPT server. And service workers don’t work from local files. Created attachment 408606 [details]
Patch
Created attachment 408612 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Committed r266984: <https://trac.webkit.org/changeset/266984> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408612 [details]. |