Summary: | REGRESSION(r266634): [macOS release] 4 layout tests became flaky failures | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||||
Component: | New Bugs | Assignee: | Sihui Liu <sihui_liu> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | darin, sihui_liu, thorton, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=216012 | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 216258 | ||||||||||
Attachments: |
|
Description
Ryan Haddad
2020-09-08 10:17:19 PDT
I was able to reproduce one of the failures with the following on r266634: run-webkit-tests compositing/tiling/tiled-mask-inwindow.html --iterations 100 --exit-after-n-failures 1 I could not reproduce with r266629. Not sure if this is fixed by the patch in https://bugs.webkit.org/show_bug.cgi?id=216261 Created attachment 408312 [details]
Patch
Created attachment 408403 [details]
Patch
Comment on attachment 408403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408403&action=review > Source/WebKit/ChangeLog:10 > + transation is committed in UI process. To make sure web process picks up the changes, we need to invoke the typo: "transition" > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:357 > +- (void)_doAfterActivityStateUpdate:(void (^)(void))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); Why is this not in WKWebViewPrivateForTesting.h? Comment on attachment 408403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408403&action=review > LayoutTests/fast/events/page-visibility-iframe-move-test.html:58 > + debug("VisibilityChanage event is received"); typo: "VisibilityChange" Comment on attachment 408403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408403&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:357 >> +- (void)_doAfterActivityStateUpdate:(void (^)(void))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); > > Why is this not in WKWebViewPrivateForTesting.h? ah, will move it to WKWebViewPrivateForTesting.h! Created attachment 408415 [details]
Patch
Comment on attachment 408415 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408415&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:79 > +- (void)_doAfterActivityStateUpdate:(void (^)(void))completionHandler; Nice! Committed r266847: <https://trac.webkit.org/changeset/266847> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408415 [details]. |