Bug 216258

Summary: REGRESSION(r266634): WKThumbnailViewResetsViewStateWhenUnparented is flaky
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: ryanhaddad, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 216275    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing ews-feeder: commit-queue-

Description Sihui Liu 2020-09-07 19:33:10 PDT 
...
Comment 1 Sihui Liu 2020-09-07 19:38:50 PDT 
Created attachment 408204 [details]
Patch
Comment 2 Sihui Liu 2020-09-07 19:49:31 PDT 
Created attachment 408205 [details]
Patch
Comment 3 Sihui Liu 2020-09-08 07:47:41 PDT 
*** Bug 216263 has been marked as a duplicate of this bug. ***
Comment 4 Ryan Haddad 2020-09-08 10:58:43 PDT 
<rdar://problem/68515242>
Comment 5 Radar WebKit Bug Importer 2020-09-08 10:58:59 PDT 
<rdar://problem/68517951>
Comment 6 Sihui Liu 2020-09-09 09:07:11 PDT 
Mark this as blocked by 216275 as this could use the SPI introduced there.
Comment 7 Sihui Liu 2020-09-10 09:59:10 PDT 
Created attachment 408454 [details]
Patch
Comment 8 Sihui Liu 2020-09-10 12:52:59 PDT 
Created attachment 408469 [details]
Patch for landing
Comment 9 EWS 2020-09-10 13:32:53 PDT 
commit-queue failed to commit attachment 408469 [details] to WebKit repository.
Comment 10 Ryan Haddad 2020-09-10 18:05:19 PDT 
(In reply to EWS from comment #9)
> commit-queue failed to commit attachment 408469 [details] to WebKit
> repository.

Left an "oops" in the changelog :(
Comment 11 Tim Horton 2020-09-10 18:12:34 PDT 
(In reply to Ryan Haddad from comment #10)
> (In reply to EWS from comment #9)
> > commit-queue failed to commit attachment 408469 [details] to WebKit
> > repository.
> 
> Left an "oops" in the changelog :(

Also the changelog is all out of order, kinda seems like a mis-conflict-resolution or something
Comment 12 Sihui Liu 2020-09-11 09:19:32 PDT 
Created attachment 408537 [details]
Patch for landing
Comment 13 EWS 2020-09-11 09:54:17 PDT 
Committed r266927: <https://trac.webkit.org/changeset/266927>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408537 [details].