Bug 216182
| Summary: | Remove stale reference to RuntimeEnabledFeatures | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, emw, graouts, ntim, thorton, webkit-bug-importer |
| Priority: | P2 | Keywords: | GoodFirstBug, InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=215962 | ||
| Bug Depends on: | 215981 | ||
| Bug Blocks: | |||
Sam Weinig
Use of WebCore::RuntimeEnabledFeatures is almost always wrong as it is a global singleton that can be set by multiple different API layer preferences objects.
Over the years, it has become convenient, as it "works" for settings that need to be accessed in non-page accessible places, but in reality, those are likely threading issues waiting to happen or layering violations due to use of RuntimeEnabledFeatures from the platform directory.
See related, 215962 (Obsolete DeprecatedGlobalSettings)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Weinig
The biggest thing to do here is likely adding a mechanism to extend WebCore::Settings (as generated from Settings.yaml) or a subset thereof, to work with Workers.
Radar WebKit Bug Importer
<rdar://problem/68714643>
Ahmad Saleem
Only able to find one incorrect include 'RuntimeEnabledFeatures' (using this search):
https://searchfox.org/wubkat/source/PerformanceTests/DecoderTest/DecoderTest/main.mm#35
and
https://searchfox.org/wubkat/source/PerformanceTests/DecoderTest/DecoderTest/main.mm#100
It also got consolidated here: https://github.com/WebKit/WebKit/commit/5ddb4127ac4e4a104338422e546a1cdc7b698769
@Tim - you reviewed above commit, do we need this bug to remain open?
@Alexey - any help if Tim is not right contact?
Alexey Proskuryakov
CC'ing some folks who worked on feature flags recently.
Tim Nguyen (:ntim)
Yeah RuntimeEnabledFeatures was removed. I'm going to repurpose this to be about removing the stale include Ahmad found.
Alexsander Borges Damaceno
Pull request: https://github.com/WebKit/WebKit/pull/45233
Sam Weinig
I removed this file (along with the whole DecoderTest directory) in https://bugs.webkit.org/show_bug.cgi?id=292936 / 593ffb9. We can close this.