Bug 216053

Summary: [ANGLE] InternalFormat::blendSupport is uninitialized by constructor
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: ANGLEAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Severity: Normal CC: dino, ews-watchlist, geofflang, graouts, jdarpinian, jonahr, kbr, kimmo.t.kinnunen, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/angleproject/issues/detail?id=5008
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2020-09-01 14:09:28 PDT
InternalFormat::blendSupport is uninitialized by its constructor.

Found by clang static analyzer using the optin.cplusplus.UninitializedObject checker.
Comment 1 Radar WebKit Bug Importer 2020-09-01 14:09:42 PDT
Comment 2 David Kilzer (:ddkilzer) 2020-09-01 14:11:14 PDT
Created attachment 407713 [details]
Patch v1
Comment 3 EWS Watchlist 2020-09-01 14:11:45 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Kenneth Russell 2020-09-01 14:12:52 PDT
CC'ing ANGLE team members - likely want this to be upstreamed to ANGLE.
Comment 5 Kenneth Russell 2020-09-01 14:13:48 PDT
Comment on attachment 407713 [details]
Patch v1

Looks good to me.
Comment 6 David Kilzer (:ddkilzer) 2020-09-01 14:14:43 PDT
Regressed in WebKit tree with Bug 206318 with commit r255782, which itself was a mere from upstream ANGLE.
Comment 7 David Kilzer (:ddkilzer) 2020-09-01 14:17:34 PDT
(In reply to Kenneth Russell from comment #4)
> CC'ing ANGLE team members - likely want this to be upstreamed to ANGLE.

Filed to track upstream:  <https://bugs.chromium.org/p/angleproject/issues/detail?id=5008>
Comment 8 David Kilzer (:ddkilzer) 2020-09-01 18:47:20 PDT
Comment on attachment 407713 [details]
Patch v1

Marking cq+ since ios-wk2 is failing due to a progression, mac-debug-wk1 has 19 scheduled test runs queued, and all other tests passed.
Comment 9 EWS 2020-09-01 18:55:35 PDT
Committed r266445: <https://trac.webkit.org/changeset/266445>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407713 [details].