Bug 215751

Summary: Import css-content tests.
Product: WebKit Reporter: Emilio Cobos Álvarez (:emilio) <emilio>
Component: CSSAssignee: Emilio Cobos Álvarez (:emilio) <emilio>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, darin, emilio, ews-watchlist, gsnedders, koivisto, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 215646    
Attachments:
Description Flags
Patch
none
Patch for landing none

Emilio Cobos Álvarez (:emilio)
Reported 2020-08-22 06:30:37 PDT
.
Attachments
Patch (169.04 KB, patch)
2020-08-22 06:55 PDT, Emilio Cobos Álvarez (:emilio) 		no flags
DetailsFormatted DiffDiff
Patch for landing (118.53 KB, patch)
2020-08-22 14:56 PDT, Emilio Cobos Álvarez (:emilio) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emilio Cobos Álvarez (:emilio)
Comment 1 2020-08-22 06:55:39 PDT
Created attachment 407050 [details] Patch
EWS
Comment 2 2020-08-22 14:09:57 PDT
Tools/Scripts/svn-apply failed to apply attachment 407050 [details] to trunk. Please resolve the conflicts and upload a new patch.
Emilio Cobos Álvarez (:emilio)
Comment 3 2020-08-22 14:40:43 PDT
It seems import-w3c-tests generates different output when ran under python2 vs. python3 (ugh!). That causes a bunch of whitespace changes in the import-expectations.json file, that caused my patch to conflict with trunk. I'll send the same patch, but generated with python2 rather than python3, as that seems to be what people are using.
Emilio Cobos Álvarez (:emilio)
Comment 4 2020-08-22 14:56:58 PDT
Created attachment 407057 [details] Patch for landing
EWS
Comment 5 2020-08-22 15:45:53 PDT
Committed r266038: <https://trac.webkit.org/changeset/266038> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407057 [details].
Radar WebKit Bug Importer
Comment 6 2020-08-22 15:46:23 PDT
<rdar://problem/67625320>
Note You need to log in before you can comment on or make changes to this bug.