Bug 215643

Summary:

overwriteCodePoint() in createAndFillGlyphPage() is wrong

Product:

WebKit

Reporter:

Hossameldin <hosskhalifa>

Component:

HTML Editing

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, corsar89, ews-watchlist, mmaxfield, sabouhallawa, siqinbilige, webkit-bug-importer, wenson_hsieh, zalan

Priority:

Keywords:

InRadar

Version:

Safari 13

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=149128

Bug Depends on:

229064

Bug Blocks:

206208, 149128, 189448, 235053

Attachments:

Description	Flags
not working on safari	none
working on firefox	none
not working on safari	none
working on firefox	none
not working properly on safari even with joiner	none
test case	none
Test case	none
WIP	none
WIP	none
WIP	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	zalan: review+
Patch for committing	none
Patch for committing	ews-feeder: commit-queue-
Patch for committing	none
Patch for committing	none
Patch for committing	ews-feeder: commit-queue-

Hossameldin

Reported 2020-08-19 04:22:32 PDT

Created attachment 406834 [details] not working on safari UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.117 Safari/537.36 Steps to reproduce the problem: Place HTML tags within an Arabic word. What is the expected behavior? The letters of the word should be joined. What went wrong? The letters of the word are separate; adding ZWJs is necessary to join them. Even adding ZWJs isn't a full resolution, as ligatures aren't used then. Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? No Does this work in other browsers? Yes OS Version: OS X 10.13.3 Here's a small discussion on this issue: https://twitter.com/KhaledGhetas/status/989311667682119681 Adding ZWJs per se isn't an an issue, but: - it's much easier to not add them - adding them doesn't render ligatures properly, like ألا - Firefox (and Edge, reportedly) don't need them. Coloring parts of Arabic words is a often needed feature, like highlighting matches, adding tajweed coloring to the Qur'an (open muqri.com, click play, and click on the ت), and so on.

Attachments
not working on safari (11.96 KB, image/png) 2020-08-19 04:22 PDT, Hossameldin	no flags	Details
working on firefox (11.58 KB, image/png) 2020-08-19 04:24 PDT, Hossameldin	no flags	Details
not working on safari (3.86 KB, image/jpeg) 2020-08-19 04:24 PDT, Hossameldin	no flags	Details
working on firefox (2.97 KB, image/jpeg) 2020-08-19 04:25 PDT, Hossameldin	no flags	Details
not working properly on safari even with joiner (2.85 KB, image/jpeg) 2020-08-19 04:27 PDT, Hossameldin	no flags	Details
test case (691 bytes, text/html) 2020-08-24 11:53 PDT, Said Abou-Hallawa	no flags	Details
Test case (5.71 KB, application/zip) 2021-08-11 16:40 PDT, Myles C. Maxfield	no flags	Details
WIP (22.28 KB, patch) 2021-08-12 13:30 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (23.04 KB, patch) 2021-08-12 13:44 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (23.18 KB, patch) 2021-08-12 13:48 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (32.69 KB, patch) 2021-08-12 18:35 PDT, Myles C. Maxfield	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (32.81 KB, patch) 2021-08-12 18:39 PDT, Myles C. Maxfield	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (20.14 KB, patch) 2021-08-12 19:05 PDT, Myles C. Maxfield	zalan: review+	Details Formatted Diff Diff
Patch for committing (17.85 KB, patch) 2021-08-20 01:33 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch for committing (25.04 KB, patch) 2021-08-20 01:35 PDT, Myles C. Maxfield	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for committing (23.23 KB, patch) 2021-08-21 12:44 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch for committing (23.22 KB, patch) 2021-08-21 12:45 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch for committing (23.84 KB, patch) 2021-08-21 13:29 PDT, Myles C. Maxfield	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Hossameldin

Comment 1 2020-08-19 04:24:13 PDT

Created attachment 406836 [details] working on firefox

Hossameldin

Comment 2 2020-08-19 04:24:44 PDT

Created attachment 406837 [details] not working on safari

Hossameldin

Comment 3 2020-08-19 04:25:04 PDT

Created attachment 406838 [details] working on firefox

Hossameldin

Comment 4 2020-08-19 04:27:22 PDT

Created attachment 406839 [details] not working properly on safari even with joiner not displaying as a ligature when using a joiner

Radar WebKit Bug Importer

Comment 5 2020-08-19 15:22:35 PDT

<rdar://problem/67430461>

Myles C. Maxfield

Comment 6 2020-08-22 19:53:23 PDT

Can you attach the HTML and CSS content which the screenshots represent?

Myles C. Maxfield

Comment 7 2020-08-22 19:53:53 PDT

Could be https://bugs.webkit.org/show_bug.cgi?id=6148

Said Abou-Hallawa

Comment 8 2020-08-24 11:53:49 PDT

Created attachment 407118 [details] test case

Said Abou-Hallawa

Comment 9 2020-08-24 12:18:55 PDT

The attached test case resembles the attached screenshots. This test case shows a bug in rendering the diacritic after the Alef (the second logical character in the third and the fourth paragraphs). Chrome and FireFox render the diacritic as expected.

Myles C. Maxfield

Comment 10 2021-03-17 00:27:24 PDT

This is because of overwriteCodePoint(zeroWidthJoiner, zeroWidthSpace); in overrideControlCharacters().

Myles C. Maxfield

Comment 11 2021-03-17 00:28:04 PDT

*** This bug has been marked as a duplicate of bug 187166 ***

Myles C. Maxfield

Comment 12 2021-03-17 00:29:24 PDT

Reverse-duping

Myles C. Maxfield

Comment 13 2021-03-17 00:29:35 PDT

*** Bug 187166 has been marked as a duplicate of this bug. ***

Myles C. Maxfield

Comment 14 2021-03-17 00:30:04 PDT

Shaping inside fonts relies on the correct glyphIDs being used. However, we replace a bunch of glyphs with the zero width space glyph, which fonts won't expect.

Myles C. Maxfield

Comment 15 2021-07-23 11:54:56 PDT

*** Bug 172205 has been marked as a duplicate of this bug. ***

Myles C. Maxfield

Comment 16 2021-08-11 00:29:05 PDT

The joiner appears to be working now. *** This bug has been marked as a duplicate of bug 6148 ***

Myles C. Maxfield

Comment 17 2021-08-11 16:33:32 PDT

Reopening, because I'd like to fix the underlying problem, even if the specific symptoms no longer occur.

Myles C. Maxfield

Comment 18 2021-08-11 16:40:28 PDT

Created attachment 435384 [details] Test case This is a test font which has a ligature to map ZWJ + B to the same glyph as p. This ligature works in Chrome and Firefox, but not in WebKit.

Myles C. Maxfield

Comment 19 2021-08-11 17:34:10 PDT

Confirmed that deleting overrideControlCharacters() fixes this.

Myles C. Maxfield

Comment 20 2021-08-12 13:30:03 PDT

Created attachment 435446 [details] WIP

Myles C. Maxfield

Comment 21 2021-08-12 13:44:40 PDT

Created attachment 435448 [details] WIP

Myles C. Maxfield

Comment 22 2021-08-12 13:48:23 PDT

Created attachment 435449 [details] WIP

Myles C. Maxfield

Comment 23 2021-08-12 16:41:20 PDT

Failing tests: fast/borders/bidi-002.html fast/borders/bidi-009a.html fast/dom/52776.html fast/text/format-control.html fast/text/international/bdi-dir-default-to-auto.html fast/text/international/bdi-neutral-wrapped.html fast/text/international/bidi-neutral-run.html fast/text/isolate-ignore.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-embed-001.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-embed-002.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-embed-003.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-embed-004.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-embed-005.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-embed-007.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-embed-008.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-embed-009.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-embed-011.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-isolate-001.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-isolate-002.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-isolate-003.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-isolate-004.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-isolate-005.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-isolate-008.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-isolate-009.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-isolate-011.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-isolate-override-001.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-isolate-override-002.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-isolate-override-003.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-isolate-override-004.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-isolate-override-005.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-isolate-override-008.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-isolate-override-009.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-isolate-override-011.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-isolate-override-012.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-normal-001.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-normal-002.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-normal-003.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-normal-004.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-normal-005.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-normal-007.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-normal-008.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-normal-009.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-normal-011.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-override-001.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-override-002.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-override-003.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-override-004.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-override-005.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-override-007.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-override-011.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-override-012.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-plaintext-001.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-plaintext-002.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-plaintext-003.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-plaintext-004.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-plaintext-005.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-plaintext-008.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-plaintext-009.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-unset-001.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-unset-002.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-unset-003.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-unset-004.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-unset-005.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-unset-007.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-unset-008.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-unset-009.html imported/blink/imported/csswg-test/css-writing-modes-3/block-embed-001.html imported/blink/imported/csswg-test/css-writing-modes-3/block-embed-002.html imported/blink/imported/csswg-test/css-writing-modes-3/block-embed-003.html imported/blink/imported/csswg-test/css-writing-modes-3/block-override-001.html imported/blink/imported/csswg-test/css-writing-modes-3/block-override-002.html imported/blink/imported/csswg-test/css-writing-modes-3/block-override-003.html imported/blink/imported/csswg-test/css-writing-modes-3/block-override-004.html imported/blink/imported/csswg-test/css-writing-modes-3/block-override-isolate-001.html imported/blink/imported/csswg-test/css-writing-modes-3/block-override-isolate-002.html imported/blink/imported/csswg-test/css-writing-modes-3/block-override-isolate-003.html imported/blink/imported/csswg-test/css-writing-modes-3/block-override-isolate-004.html imported/blink/imported/csswg-test/css-writing-modes-3/block-plaintext-001.html imported/blink/imported/csswg-test/css-writing-modes-3/block-plaintext-002.html imported/blink/imported/csswg-test/css-writing-modes-3/block-plaintext-003.html imported/blink/imported/csswg-test/css-writing-modes-3/block-plaintext-004.html imported/w3c/web-platform-tests/css/css-text/white-space/white-space-collapse-002.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-embed-001.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-embed-002.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-embed-003.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-embed-004.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-embed-005.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-embed-007.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-embed-008.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-embed-009.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-embed-011.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-isolate-001.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-isolate-002.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-isolate-003.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-isolate-004.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-isolate-005.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-isolate-008.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-isolate-009.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-isolate-011.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-isolate-override-001.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-isolate-override-002.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-isolate-override-003.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-isolate-override-004.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-isolate-override-005.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-isolate-override-008.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-isolate-override-009.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-isolate-override-011.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-isolate-override-012.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-normal-001.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-normal-002.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-normal-003.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-normal-004.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-normal-005.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-normal-007.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-normal-008.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-normal-009.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-normal-011.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-override-001.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-override-002.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-override-003.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-override-004.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-override-005.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-override-007.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-override-011.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-override-012.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-plaintext-001.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-plaintext-002.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-plaintext-003.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-plaintext-004.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-plaintext-005.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-plaintext-008.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-plaintext-009.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-unset-001.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-unset-002.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-unset-003.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-unset-004.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-unset-005.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-unset-007.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-unset-008.html imported/w3c/web-platform-tests/css/css-writing-modes/bidi-unset-009.html imported/w3c/web-platform-tests/css/css-writing-modes/block-embed-001.html imported/w3c/web-platform-tests/css/css-writing-modes/block-embed-002.html imported/w3c/web-platform-tests/css/css-writing-modes/block-embed-003.html imported/w3c/web-platform-tests/css/css-writing-modes/block-override-001.html imported/w3c/web-platform-tests/css/css-writing-modes/block-override-002.html imported/w3c/web-platform-tests/css/css-writing-modes/block-override-003.html imported/w3c/web-platform-tests/css/css-writing-modes/block-override-004.html imported/w3c/web-platform-tests/css/css-writing-modes/block-override-isolate-001.html imported/w3c/web-platform-tests/css/css-writing-modes/block-override-isolate-002.html imported/w3c/web-platform-tests/css/css-writing-modes/block-override-isolate-003.html imported/w3c/web-platform-tests/css/css-writing-modes/block-override-isolate-004.html imported/w3c/web-platform-tests/css/css-writing-modes/block-plaintext-001.html imported/w3c/web-platform-tests/css/css-writing-modes/block-plaintext-002.html imported/w3c/web-platform-tests/css/css-writing-modes/block-plaintext-003.html imported/w3c/web-platform-tests/css/css-writing-modes/block-plaintext-004.html imported/w3c/web-platform-tests/css/css-writing-modes/block-plaintext-006.html imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-isolate.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-001a.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-001b.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-001c.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-002a.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-002b.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-002c.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-003a.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-003b.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-003c.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-004a.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-004b.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-004c.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-005a.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-005b.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-005c.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-006a.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-006b.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-006c.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-007a.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-007b.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-007c.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-008a.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-008b.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-008c.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-009a.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-009b.html imported/w3c/web-platform-tests/html/dom/elements/requirements-relating-to-bidirectional-algorithm-formatting-characters/dir-isolation-009c.html imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/bdi-auto-dir-default.html imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/bdi-neutral-missing-pdf.html imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/bdi-neutral-nested.html imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/bdi-neutral-number.html imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/bdi-neutral-separate.html imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/bdi-neutral-to-another-bdi-1.html imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/bdi-neutral-to-another-bdi-2.html imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/bdi-neutral-to-letter-following-1.html imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/bdi-neutral-to-letter-following-2.html imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/bdi-neutral-to-letter-preceding-1.html imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/bdi-neutral-to-letter-preceding-2.html imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/bdi-neutral-to-number-following-1.html imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/bdi-neutral-to-number-following-2.html imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/bdi-neutral-to-surrounding-run.html imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/bdi-neutral-wrapped.html imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/bdi-paragraph-level-container.html imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-br-element/br-bidi-in-inline-ancestors.html

Myles C. Maxfield

Comment 24 2021-08-12 18:35:32 PDT

Created attachment 435461 [details] Patch

Myles C. Maxfield

Comment 25 2021-08-12 18:39:26 PDT

Created attachment 435462 [details] Patch

Myles C. Maxfield

Comment 26 2021-08-12 19:05:24 PDT

Created attachment 435464 [details] Patch

Myles C. Maxfield

Comment 27 2021-08-12 21:13:15 PDT

Comment on attachment 435464 [details] Patch Marking as r?. EWS will show some red, but that's just because this patch depends on https://bugs.webkit.org/show_bug.cgi?id=229064 which hasn't been landed yet.

zalan

Comment 28 2021-08-13 20:16:43 PDT

Comment on attachment 435464 [details] Patch :thumbsup:

Myles C. Maxfield

Comment 29 2021-08-20 01:33:55 PDT

Created attachment 435952 [details] Patch for committing

Myles C. Maxfield

Comment 30 2021-08-20 01:35:33 PDT

Created attachment 435953 [details] Patch for committing

Myles C. Maxfield

Comment 31 2021-08-21 12:13:22 PDT

Windows failures are because of https://bugs.webkit.org/show_bug.cgi?id=215318

Myles C. Maxfield

Comment 32 2021-08-21 12:44:16 PDT

Created attachment 436080 [details] Patch for committing

Myles C. Maxfield

Comment 33 2021-08-21 12:45:10 PDT

Created attachment 436081 [details] Patch for committing

Myles C. Maxfield

Comment 34 2021-08-21 13:29:02 PDT

Created attachment 436082 [details] Patch for committing

EWS

Comment 35 2021-08-21 15:41:04 PDT

Tools/Scripts/svn-apply failed to apply attachment 436082 [details] to trunk. Please resolve the conflicts and upload a new patch.

Myles C. Maxfield

Comment 36 2021-08-21 22:41:35 PDT

Committed r281389 (240804@main): <https://commits.webkit.org/240804@main>

Note You need to log in before you can comment on or make changes to this bug.